From 09920f5303ab8938c4d890867df9a7fd1cba8a07 Mon Sep 17 00:00:00 2001 From: Allen Porter Date: Thu, 20 Jan 2022 00:44:04 -0800 Subject: [PATCH] Fix rtsp-to-webrtc bug in calling client library (#64502) --- homeassistant/components/rtsp_to_webrtc/__init__.py | 2 +- tests/components/rtsp_to_webrtc/test_init.py | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/homeassistant/components/rtsp_to_webrtc/__init__.py b/homeassistant/components/rtsp_to_webrtc/__init__.py index 671654f53e9..185cfcb0240 100644 --- a/homeassistant/components/rtsp_to_webrtc/__init__.py +++ b/homeassistant/components/rtsp_to_webrtc/__init__.py @@ -67,7 +67,7 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool: """ try: async with async_timeout.timeout(TIMEOUT): - return await client.offer_stream_id(offer_sdp, stream_source, stream_id) + return await client.offer_stream_id(stream_id, offer_sdp, stream_source) except TimeoutError as err: raise HomeAssistantError("Timeout talking to RTSPtoWebRTC server") from err except ClientError as err: diff --git a/tests/components/rtsp_to_webrtc/test_init.py b/tests/components/rtsp_to_webrtc/test_init.py index 0a385ed7b92..94ec3529836 100644 --- a/tests/components/rtsp_to_webrtc/test_init.py +++ b/tests/components/rtsp_to_webrtc/test_init.py @@ -175,6 +175,13 @@ async def test_offer_for_stream_source( assert response["result"].get("answer") == ANSWER_SDP assert "error" not in response + # Validate request parameters were sent correctly + assert len(aioclient_mock.mock_calls) == 1 + assert aioclient_mock.mock_calls[-1][2] == { + "sdp64": base64.b64encode(OFFER_SDP.encode("utf-8")).decode("utf-8"), + "url": STREAM_SOURCE, + } + async def test_offer_failure( hass: HomeAssistant,