jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-13 16:27:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace linear search in unit_system with dict lookup (#125485)

Browse Source
This commit is contained in:
J. Nick Koston 2024-09-07 22:49:44 -05:00 committed by GitHub
parent ab29718a45
commit 0a11acf7ae
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
homeassistant/util/unit_system.py
View File

@ -58,23 +58,21 @@ WIND_SPEED_UNITS = SpeedConverter.VALID_UNITS
TEMPERATURE_UNITS: set[str] = {UnitOfTemperature.FAHRENHEIT, UnitOfTemperature.CELSIUS} TEMPERATURE_UNITS: set[str] = {UnitOfTemperature.FAHRENHEIT, UnitOfTemperature.CELSIUS}
_VALID_BY_TYPE: dict[str, set[str] | set[str | None]] = {
LENGTH: LENGTH_UNITS,
ACCUMULATED_PRECIPITATION: LENGTH_UNITS,
WIND_SPEED: WIND_SPEED_UNITS,
TEMPERATURE: TEMPERATURE_UNITS,
MASS: MASS_UNITS,
VOLUME: VOLUME_UNITS,
PRESSURE: PRESSURE_UNITS,
}
def _is_valid_unit(unit: str, unit_type: str) -> bool: def _is_valid_unit(unit: str, unit_type: str) -> bool:
"""Check if the unit is valid for it's type.""" """Check if the unit is valid for it's type."""
if unit_type == LENGTH: if units := _VALID_BY_TYPE.get(unit_type):
return unit in LENGTH_UNITS return unit in units
if unit_type == ACCUMULATED_PRECIPITATION:
return unit in LENGTH_UNITS
if unit_type == WIND_SPEED:
return unit in WIND_SPEED_UNITS
if unit_type == TEMPERATURE:
return unit in TEMPERATURE_UNITS
if unit_type == MASS:
return unit in MASS_UNITS
if unit_type == VOLUME:
return unit in VOLUME_UNITS
if unit_type == PRESSURE:
return unit in PRESSURE_UNITS
return False return False