jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-14 16:57:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Android TV Remote: Fix missing key and cert when adding a device via IP address (#97953)

Browse Source 
Fix missing key and cert
This commit is contained in:
tronikos 2023-08-07 05:01:35 -07:00 committed by GitHub
parent eff7b8f81a
commit 0a2ff3a676
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
homeassistant/components/androidtv_remote/config_flow.py
View File

@ -58,6 +58,7 @@ class AndroidTVRemoteConfigFlow(config_entries.ConfigFlow, domain=DOMAIN):
assert self.host assert self.host
api = create_api(self.hass, self.host, enable_ime=False) api = create_api(self.hass, self.host, enable_ime=False)
try: try:
await api.async_generate_cert_if_missing()
self.name, self.mac = await api.async_get_name_and_mac() self.name, self.mac = await api.async_get_name_and_mac()
assert self.mac assert self.mac
await self.async_set_unique_id(format_mac(self.mac)) await self.async_set_unique_id(format_mac(self.mac))

6
tests/components/androidtv_remote/test_config_flow.py
View File

@ -90,6 +90,7 @@ async def test_user_flow_cannot_connect(
host = "1.2.3.4" host = "1.2.3.4"
mock_api.async_generate_cert_if_missing = AsyncMock(return_value=True)
mock_api.async_get_name_and_mac = AsyncMock(side_effect=CannotConnect()) mock_api.async_get_name_and_mac = AsyncMock(side_effect=CannotConnect())
result = await hass.config_entries.flow.async_configure( result = await hass.config_entries.flow.async_configure(
@ -101,6 +102,7 @@ async def test_user_flow_cannot_connect(
assert "host" in result["data_schema"].schema assert "host" in result["data_schema"].schema
assert result["errors"] == {"base": "cannot_connect"} assert result["errors"] == {"base": "cannot_connect"}
mock_api.async_generate_cert_if_missing.assert_called()
mock_api.async_get_name_and_mac.assert_called() mock_api.async_get_name_and_mac.assert_called()
mock_api.async_start_pairing.assert_not_called() mock_api.async_start_pairing.assert_not_called()
@ -329,6 +331,7 @@ async def test_user_flow_already_configured_host_changed_reloads_entry(
assert "host" in result["data_schema"].schema assert "host" in result["data_schema"].schema
assert not result["errors"] assert not result["errors"]
mock_api.async_generate_cert_if_missing = AsyncMock(return_value=True)
mock_api.async_get_name_and_mac = AsyncMock(return_value=(name, mac)) mock_api.async_get_name_and_mac = AsyncMock(return_value=(name, mac))
result = await hass.config_entries.flow.async_configure( result = await hass.config_entries.flow.async_configure(
@ -338,6 +341,7 @@ async def test_user_flow_already_configured_host_changed_reloads_entry(
assert result.get("type") == FlowResultType.ABORT assert result.get("type") == FlowResultType.ABORT
assert result.get("reason") == "already_configured" assert result.get("reason") == "already_configured"
mock_api.async_generate_cert_if_missing.assert_called()
mock_api.async_get_name_and_mac.assert_called() mock_api.async_get_name_and_mac.assert_called()
mock_api.async_start_pairing.assert_not_called() mock_api.async_start_pairing.assert_not_called()
@ -386,6 +390,7 @@ async def test_user_flow_already_configured_host_not_changed_no_reload_entry(
assert "host" in result["data_schema"].schema assert "host" in result["data_schema"].schema
assert not result["errors"] assert not result["errors"]
mock_api.async_generate_cert_if_missing = AsyncMock(return_value=True)
mock_api.async_get_name_and_mac = AsyncMock(return_value=(name, mac)) mock_api.async_get_name_and_mac = AsyncMock(return_value=(name, mac))
result = await hass.config_entries.flow.async_configure( result = await hass.config_entries.flow.async_configure(
@ -395,6 +400,7 @@ async def test_user_flow_already_configured_host_not_changed_no_reload_entry(
assert result.get("type") == FlowResultType.ABORT assert result.get("type") == FlowResultType.ABORT
assert result.get("reason") == "already_configured" assert result.get("reason") == "already_configured"
mock_api.async_generate_cert_if_missing.assert_called()
mock_api.async_get_name_and_mac.assert_called() mock_api.async_get_name_and_mac.assert_called()
mock_api.async_start_pairing.assert_not_called() mock_api.async_start_pairing.assert_not_called()