jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-26 14:47:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve entity domain validator (#43164)

Browse Source
This commit is contained in:
Paulus Schoutsen 2020-11-13 13:31:43 +01:00 committed by GitHub
parent 87d86026ed
commit 0a717f313e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
homeassistant/helpers/config_validation.py
View File

@ -286,9 +286,12 @@ def entity_domain(domain: Union[str, List[str]]) -> Callable[[Any], str]:
"""Validate that entity belong to domain.""" """Validate that entity belong to domain."""
ent_domain = entities_domain(domain) ent_domain = entities_domain(domain)
def validate(value: Any) -> str: def validate(value: str) -> str:
"""Test if entity domain is domain.""" """Test if entity domain is domain."""
return ent_domain(value)[0] validated = ent_domain(value)
if len(validated) != 1:
raise vol.Invalid(f"Expected exactly 1 entity, got {len(validated)}")
return validated[0]
return validate return validate

7
tests/helpers/test_config_validation.py
View File

@ -179,7 +179,12 @@ def test_entity_domain():
"""Test entity domain validation.""" """Test entity domain validation."""
schema = vol.Schema(cv.entity_domain("sensor")) schema = vol.Schema(cv.entity_domain("sensor"))
for value in ("invalid_entity", "cover.demo"): for value in (
"invalid_entity",
"cover.demo",
"cover.demo,sensor.another_entity",
"",
):
with pytest.raises(vol.MultipleInvalid): with pytest.raises(vol.MultipleInvalid):
schema(value) schema(value)