From 0b60b86917ffa1df609759f067be9a2edf24e7b4 Mon Sep 17 00:00:00 2001 From: jan iversen Date: Mon, 19 Jul 2021 17:45:03 +0200 Subject: [PATCH] Correct typing in azure_devops and activate mypy (#53152) Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> --- homeassistant/components/azure_devops/__init__.py | 2 +- homeassistant/components/azure_devops/sensor.py | 5 ++--- mypy.ini | 3 --- script/hassfest/mypy_config.py | 1 - 4 files changed, 3 insertions(+), 8 deletions(-) diff --git a/homeassistant/components/azure_devops/__init__.py b/homeassistant/components/azure_devops/__init__.py index f5537a63291..d8b326bf2d5 100644 --- a/homeassistant/components/azure_devops/__init__.py +++ b/homeassistant/components/azure_devops/__init__.py @@ -85,7 +85,7 @@ class AzureDevOpsDeviceEntity(AzureDevOpsEntity): """Return device information about this Azure DevOps instance.""" return { "identifiers": { - ( + ( # type: ignore DOMAIN, self.organization, self.project, diff --git a/homeassistant/components/azure_devops/sensor.py b/homeassistant/components/azure_devops/sensor.py index d7589cf5014..ee3a0356a52 100644 --- a/homeassistant/components/azure_devops/sensor.py +++ b/homeassistant/components/azure_devops/sensor.py @@ -97,7 +97,7 @@ class AzureDevOpsLatestBuildSensor(AzureDevOpsSensor): "mdi:pipe", ) - async def _azure_devops_update(self) -> bool: + async def _azure_devops_update(self) -> None: """Update Azure DevOps entity.""" try: build: DevOpsBuild = await self.client.get_build( @@ -106,7 +106,7 @@ class AzureDevOpsLatestBuildSensor(AzureDevOpsSensor): except aiohttp.ClientError as exception: _LOGGER.warning(exception) self._attr_available = False - return False + return self._attr_state = build.build_number self._attr_extra_state_attributes = { "definition_id": build.definition.id, @@ -123,4 +123,3 @@ class AzureDevOpsLatestBuildSensor(AzureDevOpsSensor): "finish_time": build.finish_time, } self._attr_available = True - return True diff --git a/mypy.ini b/mypy.ini index 6245144f54f..e98094ce058 100644 --- a/mypy.ini +++ b/mypy.ini @@ -1097,9 +1097,6 @@ ignore_errors = true [mypy-homeassistant.components.awair.*] ignore_errors = true -[mypy-homeassistant.components.azure_devops.*] -ignore_errors = true - [mypy-homeassistant.components.azure_event_hub.*] ignore_errors = true diff --git a/script/hassfest/mypy_config.py b/script/hassfest/mypy_config.py index f0f7abe7b7e..c4ff71299e3 100644 --- a/script/hassfest/mypy_config.py +++ b/script/hassfest/mypy_config.py @@ -24,7 +24,6 @@ IGNORED_MODULES: Final[list[str]] = [ "homeassistant.components.atag.*", "homeassistant.components.aurora.*", "homeassistant.components.awair.*", - "homeassistant.components.azure_devops.*", "homeassistant.components.azure_event_hub.*", "homeassistant.components.blueprint.*", "homeassistant.components.bmw_connected_drive.*",