jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-27 15:17:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure that HomeKit names start and end with alphanumeric character (#126413)

Browse Source
This commit is contained in:
Indrajit Raychaudhuri 2024-09-24 11:18:17 -05:00 committed by GitHub
parent d81e836b37
commit 0bf90d18ef
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
homeassistant/components/homekit/util.py
View File

@ -114,6 +114,7 @@ _LOGGER = logging.getLogger(__name__)
NUMBERS_ONLY_RE = re.compile(r"[^\d.]+") NUMBERS_ONLY_RE = re.compile(r"[^\d.]+")
VERSION_RE = re.compile(r"([0-9]+)(\.[0-9]+)?(\.[0-9]+)?") VERSION_RE = re.compile(r"([0-9]+)(\.[0-9]+)?(\.[0-9]+)?")
INVALID_END_CHARS = "-_"
MAX_VERSION_PART = 2**32 - 1 MAX_VERSION_PART = 2**32 - 1
@ -414,7 +415,11 @@ def cleanup_name_for_homekit(name: str | None) -> str:
# likely isn't a problem # likely isn't a problem
if name is None: if name is None:
return "None" # None crashes apple watches return "None" # None crashes apple watches
return name.translate(HOMEKIT_CHAR_TRANSLATIONS)[:MAX_NAME_LENGTH] return (
name.translate(HOMEKIT_CHAR_TRANSLATIONS)
.lstrip(INVALID_END_CHARS)[:MAX_NAME_LENGTH]
.rstrip(INVALID_END_CHARS)
)
def temperature_to_homekit(temperature: float, unit: str) -> float: def temperature_to_homekit(temperature: float, unit: str) -> float:

2
tests/components/homekit/test_type_sensors.py
View File

@ -655,7 +655,7 @@ async def test_bad_name(hass: HomeAssistant, hk_driver) -> None:
assert acc.category == 10 # Sensor assert acc.category == 10 # Sensor
assert acc.char_humidity.value == 20 assert acc.char_humidity.value == 20
assert acc.display_name == "--Humid--" assert acc.display_name == "Humid"
async def test_empty_name(hass: HomeAssistant, hk_driver) -> None: async def test_empty_name(hass: HomeAssistant, hk_driver) -> None: