jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-20 03:37:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove Configuration CC as choice in zwave_js value device condition (#54962)

Browse Source
This commit is contained in:
Raman Gupta 2021-08-21 00:09:27 -04:00 committed by GitHub
parent 8796eaec81
commit 1075a65bbd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
homeassistant/components/zwave_js/device_condition.py
View File

@ -193,6 +193,8 @@ async def async_get_condition_capabilities(
return {"extra_fields": vol.Schema({vol.Required(ATTR_VALUE): value_schema})} return {"extra_fields": vol.Schema({vol.Required(ATTR_VALUE): value_schema})}
if config[CONF_TYPE] == VALUE_TYPE: if config[CONF_TYPE] == VALUE_TYPE:
# Only show command classes on this node and exclude Configuration CC since it
# is already covered
return { return {
"extra_fields": vol.Schema( "extra_fields": vol.Schema(
{ {
@ -200,6 +202,7 @@ async def async_get_condition_capabilities(
{ {
CommandClass(cc.id).value: CommandClass(cc.id).name CommandClass(cc.id).value: CommandClass(cc.id).name
for cc in sorted(node.command_classes, key=lambda cc: cc.name) # type: ignore[no-any-return] for cc in sorted(node.command_classes, key=lambda cc: cc.name) # type: ignore[no-any-return]
if cc.id != CommandClass.CONFIGURATION
} }
), ),
vol.Required(ATTR_PROPERTY): cv.string, vol.Required(ATTR_PROPERTY): cv.string,

1
tests/components/zwave_js/test_device_condition.py
View File

@ -433,7 +433,6 @@ async def test_get_condition_capabilities_value(
cc_options = [ cc_options = [
(133, "ASSOCIATION"), (133, "ASSOCIATION"),
(128, "BATTERY"), (128, "BATTERY"),
(112, "CONFIGURATION"),
(98, "DOOR_LOCK"), (98, "DOOR_LOCK"),
(122, "FIRMWARE_UPDATE_MD"), (122, "FIRMWARE_UPDATE_MD"),
(114, "MANUFACTURER_SPECIFIC"), (114, "MANUFACTURER_SPECIFIC"),