From 107994f3ac39b60b389fa4d7eb4efbb284b70a10 Mon Sep 17 00:00:00 2001 From: "nkgilley@gmail.com" Date: Thu, 3 Dec 2015 08:57:28 -0500 Subject: [PATCH] implement logic improvement suggestion by @balloob --- homeassistant/components/sensor/ecobee.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/homeassistant/components/sensor/ecobee.py b/homeassistant/components/sensor/ecobee.py index 9f4b6ef23e0..02a2575d88b 100644 --- a/homeassistant/components/sensor/ecobee.py +++ b/homeassistant/components/sensor/ecobee.py @@ -53,15 +53,11 @@ def setup_platform(hass, config, add_devices, discovery_info=None): for index in range(len(data.ecobee.thermostats)): for sensor in data.ecobee.get_remote_sensors(index): for item in sensor['capability']: - if item['type'] == 'temperature': - dev.append( - EcobeeSensor(sensor['name'], 'temperature', index)) - elif item['type'] == 'humidity': - dev.append( - EcobeeSensor(sensor['name'], 'humidity', index)) - elif item['type'] == 'occupancy': - dev.append( - EcobeeSensor(sensor['name'], 'occupancy', index)) + if item['type'] not in ('temperature', + 'humidity', 'occupancy'): + continue + + dev.append(EcobeeSensor(sensor['name'], item['type'], index)) add_devices(dev)