mirror of
https://github.com/home-assistant/core.git
synced 2025-07-23 05:07:41 +00:00
Gracefully handle empty summary in google calendar (#69520)
Gracefully handle empty summary in google calendar matching the old behavior before some code cleanup.
This commit is contained in:
parent
fbea950eb0
commit
10a1b1f734
@ -183,7 +183,9 @@ class GoogleCalendarEventDevice(CalendarEventDevice):
|
|||||||
valid_items = filter(self._event_filter, items)
|
valid_items = filter(self._event_filter, items)
|
||||||
self._event = copy.deepcopy(next(valid_items, None))
|
self._event = copy.deepcopy(next(valid_items, None))
|
||||||
if self._event:
|
if self._event:
|
||||||
(summary, offset) = extract_offset(self._event["summary"], self._offset)
|
(summary, offset) = extract_offset(
|
||||||
|
self._event.get("summary", ""), self._offset
|
||||||
|
)
|
||||||
self._event["summary"] = summary
|
self._event["summary"] = summary
|
||||||
self._offset_reached = is_offset_reached(
|
self._offset_reached = is_offset_reached(
|
||||||
get_date(self._event["start"]), offset
|
get_date(self._event["start"]), offset
|
||||||
|
@ -272,6 +272,35 @@ async def test_all_day_offset_event(hass, mock_events_list_items, component_setu
|
|||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
async def test_missing_summary(hass, mock_events_list_items, component_setup):
|
||||||
|
"""Test that we can create an event trigger on device."""
|
||||||
|
start_event = dt_util.now() + datetime.timedelta(minutes=14)
|
||||||
|
end_event = start_event + datetime.timedelta(minutes=60)
|
||||||
|
event = {
|
||||||
|
**TEST_EVENT,
|
||||||
|
"start": {"dateTime": start_event.isoformat()},
|
||||||
|
"end": {"dateTime": end_event.isoformat()},
|
||||||
|
}
|
||||||
|
del event["summary"]
|
||||||
|
mock_events_list_items([event])
|
||||||
|
|
||||||
|
assert await component_setup()
|
||||||
|
|
||||||
|
state = hass.states.get(TEST_ENTITY)
|
||||||
|
assert state.name == TEST_ENTITY_NAME
|
||||||
|
assert state.state == STATE_OFF
|
||||||
|
assert dict(state.attributes) == {
|
||||||
|
"friendly_name": TEST_ENTITY_NAME,
|
||||||
|
"message": "",
|
||||||
|
"all_day": False,
|
||||||
|
"offset_reached": False,
|
||||||
|
"start_time": start_event.strftime(DATE_STR_FORMAT),
|
||||||
|
"end_time": end_event.strftime(DATE_STR_FORMAT),
|
||||||
|
"location": event["location"],
|
||||||
|
"description": event["description"],
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
async def test_update_error(
|
async def test_update_error(
|
||||||
hass, calendar_resource, component_setup, test_api_calendar
|
hass, calendar_resource, component_setup, test_api_calendar
|
||||||
):
|
):
|
||||||
|
Loading…
x
Reference in New Issue
Block a user