From 11b1a42a1c65a689af264471560259767cba2a54 Mon Sep 17 00:00:00 2001
From: Joost Lekkerkerker <joostlek@outlook.com>
Date: Mon, 14 Aug 2023 12:52:27 +0200
Subject: [PATCH] Add entity translations to Aseko (#98117)

---
 .../aseko_pool_live/binary_sensor.py          |  5 ++---
 .../components/aseko_pool_live/entity.py      |  2 ++
 .../components/aseko_pool_live/sensor.py      | 15 +++++++------
 .../components/aseko_pool_live/strings.json   | 21 +++++++++++++++++++
 4 files changed, 34 insertions(+), 9 deletions(-)

diff --git a/homeassistant/components/aseko_pool_live/binary_sensor.py b/homeassistant/components/aseko_pool_live/binary_sensor.py
index 8178e243279..3e0e57fffac 100644
--- a/homeassistant/components/aseko_pool_live/binary_sensor.py
+++ b/homeassistant/components/aseko_pool_live/binary_sensor.py
@@ -37,19 +37,18 @@ class AsekoBinarySensorEntityDescription(
 UNIT_BINARY_SENSORS: tuple[AsekoBinarySensorEntityDescription, ...] = (
     AsekoBinarySensorEntityDescription(
         key="water_flow",
-        name="Water Flow",
+        translation_key="water_flow",
         icon="mdi:waves-arrow-right",
         value_fn=lambda unit: unit.water_flow,
     ),
     AsekoBinarySensorEntityDescription(
         key="has_alarm",
-        name="Alarm",
+        translation_key="alarm",
         value_fn=lambda unit: unit.has_alarm,
         device_class=BinarySensorDeviceClass.SAFETY,
     ),
     AsekoBinarySensorEntityDescription(
         key="has_error",
-        name="Error",
         value_fn=lambda unit: unit.has_error,
         device_class=BinarySensorDeviceClass.PROBLEM,
     ),
diff --git a/homeassistant/components/aseko_pool_live/entity.py b/homeassistant/components/aseko_pool_live/entity.py
index 54afc80d451..1defbe18345 100644
--- a/homeassistant/components/aseko_pool_live/entity.py
+++ b/homeassistant/components/aseko_pool_live/entity.py
@@ -11,6 +11,8 @@ from .coordinator import AsekoDataUpdateCoordinator
 class AsekoEntity(CoordinatorEntity[AsekoDataUpdateCoordinator]):
     """Representation of an aseko entity."""
 
+    _attr_has_entity_name = True
+
     def __init__(self, unit: Unit, coordinator: AsekoDataUpdateCoordinator) -> None:
         """Initialize the aseko entity."""
         super().__init__(coordinator)
diff --git a/homeassistant/components/aseko_pool_live/sensor.py b/homeassistant/components/aseko_pool_live/sensor.py
index 09c4af31428..d7e5e330705 100644
--- a/homeassistant/components/aseko_pool_live/sensor.py
+++ b/homeassistant/components/aseko_pool_live/sensor.py
@@ -45,13 +45,16 @@ class VariableSensorEntity(AsekoEntity, SensorEntity):
         super().__init__(unit, coordinator)
         self._variable = variable
 
-        variable_name = {
-            "Air temp.": "Air Temperature",
-            "Cl free": "Free Chlorine",
-            "Water temp.": "Water Temperature",
-        }.get(self._variable.name, self._variable.name)
+        translation_key = {
+            "Air temp.": "air_temperature",
+            "Cl free": "free_chlorine",
+            "Water temp.": "water_temperature",
+        }.get(self._variable.name)
+        if translation_key is not None:
+            self._attr_translation_key = translation_key
+        else:
+            self._attr_name = self._variable.name
 
-        self._attr_name = f"{self._device_name} {variable_name}"
         self._attr_unique_id = f"{self._unit.serial_number}{self._variable.type}"
         self._attr_native_unit_of_measurement = self._variable.unit
 
diff --git a/homeassistant/components/aseko_pool_live/strings.json b/homeassistant/components/aseko_pool_live/strings.json
index 7a91b2c9f8b..2a6df30b148 100644
--- a/homeassistant/components/aseko_pool_live/strings.json
+++ b/homeassistant/components/aseko_pool_live/strings.json
@@ -16,5 +16,26 @@
     "abort": {
       "already_configured": "[%key:common::config_flow::abort::already_configured_account%]"
     }
+  },
+  "entity": {
+    "binary_sensor": {
+      "water_flow": {
+        "name": "Water flow"
+      },
+      "alarm": {
+        "name": "Alarm"
+      }
+    },
+    "sensor": {
+      "air_temperature": {
+        "name": "Air temperature"
+      },
+      "free_chlorine": {
+        "name": "Free chlorine"
+      },
+      "water_temperature": {
+        "name": "Water temperature"
+      }
+    }
   }
 }