jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 13:17:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle case where location_name is set to "" for zeroconf (#54880)

Browse Source
This commit is contained in:
J. Nick Koston 2021-08-20 16:33:23 -05:00 committed by GitHub
parent 3cb7227040
commit 1325b38256
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/components/zeroconf/__init__.py
View File

@ -215,7 +215,9 @@ async def _async_register_hass_zc_service(
hass: HomeAssistant, aio_zc: HaAsyncZeroconf, uuid: str hass: HomeAssistant, aio_zc: HaAsyncZeroconf, uuid: str
) -> None: ) -> None:
# Get instance UUID # Get instance UUID
valid_location_name = _truncate_location_name_to_valid(hass.config.location_name) valid_location_name = _truncate_location_name_to_valid(
hass.config.location_name or "Home"
)
params = { params = {
"location_name": valid_location_name, "location_name": valid_location_name,

15
tests/components/zeroconf/test_init.py
View File

@ -39,7 +39,7 @@ def service_update_mock(ipv6, zeroconf, services, handlers, *, limit_service=Non
handlers[0](zeroconf, service, f"_name.{service}", ServiceStateChange.Added) handlers[0](zeroconf, service, f"_name.{service}", ServiceStateChange.Added)
def get_service_info_mock(service_type, name): def get_service_info_mock(service_type, name, *args, **kwargs):
"""Return service info for get_service_info.""" """Return service info for get_service_info."""
return AsyncServiceInfo( return AsyncServiceInfo(
service_type, service_type,
@ -872,3 +872,16 @@ async def test_async_detect_interfaces_explicitly_set_ipv6(hass, mock_async_zero
interfaces=["192.168.1.5", "fe80::dead:beef:dead:beef"], interfaces=["192.168.1.5", "fe80::dead:beef:dead:beef"],
ip_version=IPVersion.All, ip_version=IPVersion.All,
) )
async def test_no_name(hass, mock_async_zeroconf):
"""Test fallback to Home for mDNS announcement if the name is missing."""
hass.config.location_name = ""
with patch("homeassistant.components.zeroconf.HaZeroconf"):
assert await async_setup_component(hass, zeroconf.DOMAIN, {zeroconf.DOMAIN: {}})
hass.bus.async_fire(EVENT_HOMEASSISTANT_START)
await hass.async_block_till_done()
register_call = mock_async_zeroconf.async_register_service.mock_calls[-1]
info = register_call.args[0]
assert info.name == "Home._home-assistant._tcp.local."