jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-27 23:27:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't generate mypy.ini if errors are found (#50456)

Browse Source
This commit is contained in:
Ruslan Sayfutdinov 2021-05-11 13:29:14 +01:00 committed by GitHub
parent 236f138ab7
commit 1538271555
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
script/hassfest/mypy_config.py
View File

@ -308,7 +308,9 @@ def generate_and_validate(config: Config) -> str:
"mypy_config", f"Only components should be added: {module}" "mypy_config", f"Only components should be added: {module}"
) )
if module in ignored_modules_set: if module in ignored_modules_set:
config.add_error("mypy_config", f"Module '{module}' is in ignored list") config.add_error(
"mypy_config", f"Module '{module}' is in ignored list in mypy_config.py"
)
# Validate that all modules exist. # Validate that all modules exist.
all_modules = strict_modules + IGNORED_MODULES all_modules = strict_modules + IGNORED_MODULES
@ -326,6 +328,10 @@ def generate_and_validate(config: Config) -> str:
if not module_path.is_file(): if not module_path.is_file():
config.add_error("mypy_config", f"Module '{module} doesn't exist") config.add_error("mypy_config", f"Module '{module} doesn't exist")
# Don't generate mypy.ini if there're errors found because it will likely crash.
if config.errors:
return ""
mypy_config = configparser.ConfigParser() mypy_config = configparser.ConfigParser()
general_section = "mypy" general_section = "mypy"
@ -369,6 +375,9 @@ def validate(integrations: dict[str, Integration], config: Config) -> None:
config_path = config.root / "mypy.ini" config_path = config.root / "mypy.ini"
config.cache["mypy_config"] = content = generate_and_validate(config) config.cache["mypy_config"] = content = generate_and_validate(config)
if config.errors:
return
with open(str(config_path)) as fp: with open(str(config_path)) as fp:
if fp.read().strip() != content: if fp.read().strip() != content:
config.add_error( config.add_error(