jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 13:17:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

DSMR: Small cleanup; use entity class attributes (#52143)

Browse Source
This commit is contained in:
Franck Nijhof 2021-06-24 11:25:19 +02:00 committed by GitHub
parent e21325b975
commit 17357bf575
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
homeassistant/components/dsmr/sensor.py
View File

@ -23,7 +23,6 @@ from homeassistant.const import (
) )
from homeassistant.core import CoreState, HomeAssistant, callback from homeassistant.core import CoreState, HomeAssistant, callback
from homeassistant.helpers import config_validation as cv from homeassistant.helpers import config_validation as cv
from homeassistant.helpers.entity import DeviceInfo
from homeassistant.util import Throttle from homeassistant.util import Throttle
from .const import ( from .const import (
@ -289,17 +288,21 @@ async def async_setup_entry(
class DSMREntity(SensorEntity): class DSMREntity(SensorEntity):
"""Entity reading values from DSMR telegram.""" """Entity reading values from DSMR telegram."""
_attr_should_poll = False
def __init__(self, name, device_name, device_serial, obis, config, force_update): def __init__(self, name, device_name, device_serial, obis, config, force_update):
"""Initialize entity.""" """Initialize entity."""
self._name = name
self._obis = obis self._obis = obis
self._config = config self._config = config
self.telegram = {} self.telegram = {}
self._device_name = device_name self._attr_name = name
self._device_serial = device_serial self._attr_force_update = force_update
self._force_update = force_update self._attr_unique_id = f"{device_serial}_{name}".replace(" ", "_")
self._unique_id = f"{device_serial}_{name}".replace(" ", "_") self._attr_device_info = {
"identifiers": {(DOMAIN, device_serial)},
"name": device_name,
}
@callback @callback
def update_data(self, telegram): def update_data(self, telegram):
@ -318,21 +321,16 @@ class DSMREntity(SensorEntity):
dsmr_object = self.telegram[self._obis] dsmr_object = self.telegram[self._obis]
return getattr(dsmr_object, attribute, None) return getattr(dsmr_object, attribute, None)
@property
def name(self):
"""Return the name of the sensor."""
return self._name
@property @property
def icon(self): def icon(self):
"""Icon to use in the frontend, if any.""" """Icon to use in the frontend, if any."""
if "Sags" in self._name or "Swells" in self.name: if "Sags" in self.name or "Swells" in self.name:
return ICON_SWELL_SAG return ICON_SWELL_SAG
if "Failure" in self._name: if "Failure" in self.name:
return ICON_POWER_FAILURE return ICON_POWER_FAILURE
if "Power" in self._name: if "Power" in self.name:
return ICON_POWER return ICON_POWER
if "Gas" in self._name: if "Gas" in self.name:
return ICON_GAS return ICON_GAS
@property @property
@ -358,29 +356,6 @@ class DSMREntity(SensorEntity):
"""Return the unit of measurement of this entity, if any.""" """Return the unit of measurement of this entity, if any."""
return self.get_dsmr_object_attr("unit") return self.get_dsmr_object_attr("unit")
@property
def unique_id(self) -> str:
"""Return a unique ID."""
return self._unique_id
@property
def device_info(self) -> DeviceInfo:
"""Return the device information."""
return {
"identifiers": {(DOMAIN, self._device_serial)},
"name": self._device_name,
}
@property
def force_update(self):
"""Force update."""
return self._force_update
@property
def should_poll(self):
"""Disable polling."""
return False
@staticmethod @staticmethod
def translate_tariff(value, dsmr_version): def translate_tariff(value, dsmr_version):
"""Convert 2/1 to normal/low depending on DSMR version.""" """Convert 2/1 to normal/low depending on DSMR version."""