jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-04 03:47:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Explicitly pass in the config_entry in Feedreader coordinator init (#136777)

Browse Source
This commit is contained in:
Michael 2025-01-29 01:08:27 +01:00 committed by GitHub
parent fa2aeae30f
commit 177bb29f69
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 20 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
homeassistant/components/feedreader/__init__.py
View File

@ -2,15 +2,12 @@
from __future__ import annotations from __future__ import annotations
from homeassistant.config_entries import ConfigEntry from homeassistant.const import Platform
from homeassistant.const import CONF_URL, Platform
from homeassistant.core import HomeAssistant from homeassistant.core import HomeAssistant
from homeassistant.util.hass_dict import HassKey from homeassistant.util.hass_dict import HassKey
from .const import CONF_MAX_ENTRIES, DOMAIN from .const import DOMAIN
from .coordinator import FeedReaderCoordinator, StoredData from .coordinator import FeedReaderConfigEntry, FeedReaderCoordinator, StoredData
type FeedReaderConfigEntry = ConfigEntry[FeedReaderCoordinator]
CONF_URLS = "urls" CONF_URLS = "urls"
@ -23,12 +20,7 @@ async def async_setup_entry(hass: HomeAssistant, entry: FeedReaderConfigEntry) -
if not storage.is_initialized: if not storage.is_initialized:
await storage.async_setup() await storage.async_setup()
coordinator = FeedReaderCoordinator( coordinator = FeedReaderCoordinator(hass, entry, storage)
hass,
entry.data[CONF_URL],
entry.options[CONF_MAX_ENTRIES],
storage,
)
await coordinator.async_setup() await coordinator.async_setup()

29
homeassistant/components/feedreader/coordinator.py
View File

@ -13,13 +13,14 @@ from urllib.error import URLError
import feedparser import feedparser
from homeassistant.config_entries import ConfigEntry from homeassistant.config_entries import ConfigEntry
from homeassistant.const import CONF_URL
from homeassistant.core import HomeAssistant, callback from homeassistant.core import HomeAssistant, callback
from homeassistant.exceptions import ConfigEntryNotReady from homeassistant.exceptions import ConfigEntryNotReady
from homeassistant.helpers.storage import Store from homeassistant.helpers.storage import Store
from homeassistant.helpers.update_coordinator import DataUpdateCoordinator, UpdateFailed from homeassistant.helpers.update_coordinator import DataUpdateCoordinator, UpdateFailed
from homeassistant.util import dt as dt_util from homeassistant.util import dt as dt_util
from .const import DEFAULT_SCAN_INTERVAL, DOMAIN, EVENT_FEEDREADER from .const import CONF_MAX_ENTRIES, DEFAULT_SCAN_INTERVAL, DOMAIN, EVENT_FEEDREADER
DELAY_SAVE = 30 DELAY_SAVE = 30
STORAGE_VERSION = 1 STORAGE_VERSION = 1
@ -27,37 +28,39 @@ STORAGE_VERSION = 1
_LOGGER = getLogger(__name__) _LOGGER = getLogger(__name__)
type FeedReaderConfigEntry = ConfigEntry[FeedReaderCoordinator]
class FeedReaderCoordinator( class FeedReaderCoordinator(
DataUpdateCoordinator[list[feedparser.FeedParserDict] | None] DataUpdateCoordinator[list[feedparser.FeedParserDict] | None]
): ):
"""Abstraction over Feedparser module.""" """Abstraction over Feedparser module."""
config_entry: ConfigEntry config_entry: FeedReaderConfigEntry
def __init__( def __init__(
self, self,
hass: HomeAssistant, hass: HomeAssistant,
url: str, config_entry: FeedReaderConfigEntry,
max_entries: int,
storage: StoredData, storage: StoredData,
) -> None: ) -> None:
"""Initialize the FeedManager object, poll as per scan interval.""" """Initialize the FeedManager object, poll as per scan interval."""
super().__init__( self.url = config_entry.data[CONF_URL]
hass=hass,
logger=_LOGGER,
name=f"{DOMAIN} {url}",
update_interval=DEFAULT_SCAN_INTERVAL,
)
self.url = url
self.feed_author: str | None = None self.feed_author: str | None = None
self.feed_version: str | None = None self.feed_version: str | None = None
self._max_entries = max_entries self._max_entries = config_entry.options[CONF_MAX_ENTRIES]
self._storage = storage self._storage = storage
self._last_entry_timestamp: struct_time | None = None self._last_entry_timestamp: struct_time | None = None
self._event_type = EVENT_FEEDREADER self._event_type = EVENT_FEEDREADER
self._feed: feedparser.FeedParserDict | None = None self._feed: feedparser.FeedParserDict | None = None
self._feed_id = url self._feed_id = self.url
super().__init__(
hass=hass,
logger=_LOGGER,
config_entry=config_entry,
name=f"{DOMAIN} {self.url}",
update_interval=DEFAULT_SCAN_INTERVAL,
)
@callback @callback
def _log_no_entries(self) -> None: def _log_no_entries(self) -> None: