Address late review for Tractive integration (#55371)

This commit is contained in:
Maciej Bieniek 2021-08-28 17:49:34 +02:00 committed by GitHub
parent 2fcd77098d
commit 19873e6547
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -29,7 +29,6 @@ from .entity import TractiveEntity
class TractiveSensorEntityDescription(SensorEntityDescription):
"""Class describing Tractive sensor entities."""
attributes: tuple = ()
entity_class: type[TractiveSensor] | None = None
@ -97,10 +96,6 @@ class TractiveActivitySensor(TractiveSensor):
def handle_activity_status_update(self, event):
"""Handle activity status update."""
self._attr_native_value = event[self.entity_description.key]
self._attr_extra_state_attributes = {
attr: event[attr] if attr in event else None
for attr in self.entity_description.attributes
}
self._attr_available = True
self.async_write_ha_state()
@ -137,7 +132,13 @@ SENSOR_TYPES = (
name="Minutes Active",
icon="mdi:clock-time-eight-outline",
native_unit_of_measurement=TIME_MINUTES,
attributes=(ATTR_DAILY_GOAL,),
entity_class=TractiveActivitySensor,
),
TractiveSensorEntityDescription(
key=ATTR_DAILY_GOAL,
name="Daily Goal",
icon="mdi:flag-checkered",
native_unit_of_measurement=TIME_MINUTES,
entity_class=TractiveActivitySensor,
),
)