jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-09 14:27:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use constants for device registry checks (#58514)

Browse Source 
Co-authored-by: epenet <epenet@users.noreply.github.com>
This commit is contained in:
epenet 2021-10-27 11:34:58 +02:00 committed by GitHub
parent 91b07cce20
commit 19eba5a3a0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 36 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tests/components/arcam_fmj/test_media_player.py
View File

@ -12,7 +12,13 @@ from homeassistant.components.media_player.const import (
MEDIA_TYPE_MUSIC, MEDIA_TYPE_MUSIC,
SERVICE_SELECT_SOURCE, SERVICE_SELECT_SOURCE,
) )
from homeassistant.const import ATTR_ENTITY_ID from homeassistant.const import (
ATTR_ENTITY_ID,
ATTR_IDENTIFIERS,
ATTR_MANUFACTURER,
ATTR_MODEL,
ATTR_NAME,
)
from .conftest import MOCK_HOST, MOCK_NAME, MOCK_PORT, MOCK_UUID from .conftest import MOCK_HOST, MOCK_NAME, MOCK_PORT, MOCK_UUID
@ -32,10 +38,13 @@ async def test_properties(player, state):
"""Test standard properties.""" """Test standard properties."""
assert player.unique_id == f"{MOCK_UUID}-1" assert player.unique_id == f"{MOCK_UUID}-1"
assert player.device_info == { assert player.device_info == {
"name": f"Arcam FMJ ({MOCK_HOST})", ATTR_NAME: f"Arcam FMJ ({MOCK_HOST})",
"identifiers": {("arcam_fmj", MOCK_UUID), ("arcam_fmj", MOCK_HOST, MOCK_PORT)}, ATTR_IDENTIFIERS: {
"model": "Arcam FMJ AVR", ("arcam_fmj", MOCK_UUID),
"manufacturer": "Arcam", ("arcam_fmj", MOCK_HOST, MOCK_PORT),
},
ATTR_MODEL: "Arcam FMJ AVR",
ATTR_MANUFACTURER: "Arcam",
} }
assert not player.should_poll assert not player.should_poll

38
tests/components/nest/test_device_info.py
View File

@ -3,6 +3,12 @@
from google_nest_sdm.device import Device from google_nest_sdm.device import Device
from homeassistant.components.nest.device_info import NestDeviceInfo from homeassistant.components.nest.device_info import NestDeviceInfo
from homeassistant.const import (
ATTR_IDENTIFIERS,
ATTR_MANUFACTURER,
ATTR_MODEL,
ATTR_NAME,
)
def test_device_custom_name(): def test_device_custom_name():
@ -25,10 +31,10 @@ def test_device_custom_name():
assert device_info.device_model == "Doorbell" assert device_info.device_model == "Doorbell"
assert device_info.device_brand == "Google Nest" assert device_info.device_brand == "Google Nest"
assert device_info.device_info == { assert device_info.device_info == {
"identifiers": {("nest", "some-device-id")}, ATTR_IDENTIFIERS: {("nest", "some-device-id")},
"name": "My Doorbell", ATTR_NAME: "My Doorbell",
"manufacturer": "Google Nest", ATTR_MANUFACTURER: "Google Nest",
"model": "Doorbell", ATTR_MODEL: "Doorbell",
} }
@ -50,10 +56,10 @@ def test_device_name_room():
assert device_info.device_model == "Doorbell" assert device_info.device_model == "Doorbell"
assert device_info.device_brand == "Google Nest" assert device_info.device_brand == "Google Nest"
assert device_info.device_info == { assert device_info.device_info == {
"identifiers": {("nest", "some-device-id")}, ATTR_IDENTIFIERS: {("nest", "some-device-id")},
"name": "Some Room", ATTR_NAME: "Some Room",
"manufacturer": "Google Nest", ATTR_MANUFACTURER: "Google Nest",
"model": "Doorbell", ATTR_MODEL: "Doorbell",
} }
@ -69,10 +75,10 @@ def test_device_no_name():
assert device_info.device_model == "Doorbell" assert device_info.device_model == "Doorbell"
assert device_info.device_brand == "Google Nest" assert device_info.device_brand == "Google Nest"
assert device_info.device_info == { assert device_info.device_info == {
"identifiers": {("nest", "some-device-id")}, ATTR_IDENTIFIERS: {("nest", "some-device-id")},
"name": "Doorbell", ATTR_NAME: "Doorbell",
"manufacturer": "Google Nest", ATTR_MANUFACTURER: "Google Nest",
"model": "Doorbell", ATTR_MODEL: "Doorbell",
} }
@ -96,8 +102,8 @@ def test_device_invalid_type():
assert device_info.device_model is None assert device_info.device_model is None
assert device_info.device_brand == "Google Nest" assert device_info.device_brand == "Google Nest"
assert device_info.device_info == { assert device_info.device_info == {
"identifiers": {("nest", "some-device-id")}, ATTR_IDENTIFIERS: {("nest", "some-device-id")},
"name": "My Doorbell", ATTR_NAME: "My Doorbell",
"manufacturer": "Google Nest", ATTR_MANUFACTURER: "Google Nest",
"model": None, ATTR_MODEL: None,
} }