jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-18 18:57:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Reolink callback id collision (#138918)

Browse Source
This commit is contained in:
starkillerOG 2025-02-20 10:46:24 +01:00 committed by GitHub
parent 66af5ca1e9
commit 1a56dcfdaf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
homeassistant/components/reolink/entity.py
View File

@ -107,10 +107,10 @@ class ReolinkHostCoordinatorEntity(CoordinatorEntity[DataUpdateCoordinator[None]
"""Handle incoming TCP push event.""" """Handle incoming TCP push event."""
self.async_write_ha_state() self.async_write_ha_state()
def register_callback(self, unique_id: str, cmd_id: int) -> None: def register_callback(self, callback_id: str, cmd_id: int) -> None:
"""Register callback for TCP push events.""" """Register callback for TCP push events."""
self._host.api.baichuan.register_callback( # pragma: no cover self._host.api.baichuan.register_callback( # pragma: no cover
unique_id, self._push_callback, cmd_id callback_id, self._push_callback, cmd_id
) )
async def async_added_to_hass(self) -> None: async def async_added_to_hass(self) -> None:
@ -118,23 +118,25 @@ class ReolinkHostCoordinatorEntity(CoordinatorEntity[DataUpdateCoordinator[None]
await super().async_added_to_hass() await super().async_added_to_hass()
cmd_key = self.entity_description.cmd_key cmd_key = self.entity_description.cmd_key
cmd_id = self.entity_description.cmd_id cmd_id = self.entity_description.cmd_id
callback_id = f"{self.platform.domain}_{self._attr_unique_id}"
if cmd_key is not None: if cmd_key is not None:
self._host.async_register_update_cmd(cmd_key) self._host.async_register_update_cmd(cmd_key)
if cmd_id is not None: if cmd_id is not None:
self.register_callback(self._attr_unique_id, cmd_id) self.register_callback(callback_id, cmd_id)
# Privacy mode # Privacy mode
self.register_callback(f"{self._attr_unique_id}_623", 623) self.register_callback(f"{callback_id}_623", 623)
async def async_will_remove_from_hass(self) -> None: async def async_will_remove_from_hass(self) -> None:
"""Entity removed.""" """Entity removed."""
cmd_key = self.entity_description.cmd_key cmd_key = self.entity_description.cmd_key
cmd_id = self.entity_description.cmd_id cmd_id = self.entity_description.cmd_id
callback_id = f"{self.platform.domain}_{self._attr_unique_id}"
if cmd_key is not None: if cmd_key is not None:
self._host.async_unregister_update_cmd(cmd_key) self._host.async_unregister_update_cmd(cmd_key)
if cmd_id is not None: if cmd_id is not None:
self._host.api.baichuan.unregister_callback(self._attr_unique_id) self._host.api.baichuan.unregister_callback(callback_id)
# Privacy mode # Privacy mode
self._host.api.baichuan.unregister_callback(f"{self._attr_unique_id}_623") self._host.api.baichuan.unregister_callback(f"{callback_id}_623")
await super().async_will_remove_from_hass() await super().async_will_remove_from_hass()
@ -193,10 +195,10 @@ class ReolinkChannelCoordinatorEntity(ReolinkHostCoordinatorEntity):
"""Return True if entity is available.""" """Return True if entity is available."""
return super().available and self._host.api.camera_online(self._channel) return super().available and self._host.api.camera_online(self._channel)
def register_callback(self, unique_id: str, cmd_id: int) -> None: def register_callback(self, callback_id: str, cmd_id: int) -> None:
"""Register callback for TCP push events.""" """Register callback for TCP push events."""
self._host.api.baichuan.register_callback( self._host.api.baichuan.register_callback(
unique_id, self._push_callback, cmd_id, self._channel callback_id, self._push_callback, cmd_id, self._channel
) )
async def async_added_to_hass(self) -> None: async def async_added_to_hass(self) -> None: