Fix version_bump --set-nightly-version (#114304)

This commit is contained in:
Robert Resch 2024-03-27 14:45:28 +01:00 committed by GitHub
parent ce022a1793
commit 1a64be6da6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -89,10 +89,16 @@ def bump_version(
if not version.is_devrelease: if not version.is_devrelease:
raise ValueError("Can only be run on dev release") raise ValueError("Can only be run on dev release")
to_change["dev"] = ( new_dev = dt_util.utcnow().strftime("%Y%m%d%H%M")
"dev", if nightly_version:
nightly_version or dt_util.utcnow().strftime("%Y%m%d%H%M"), new_version = Version(nightly_version)
) if new_version.release != version.release:
raise ValueError("Nightly version must have the same release version")
if not new_version.is_devrelease:
raise ValueError("Nightly version must be a dev version")
new_dev = new_version.dev
to_change["dev"] = ("dev", new_dev)
else: else:
raise ValueError(f"Unsupported type: {bump_type}") raise ValueError(f"Unsupported type: {bump_type}")
@ -223,10 +229,22 @@ def test_bump_version() -> None:
f"0.56.0.dev{now}" f"0.56.0.dev{now}"
) )
assert bump_version( assert bump_version(
Version("0.56.0.dev0"), "nightly", nightly_version="1234" Version("2024.4.0.dev20240327"),
) == Version("0.56.0.dev1234") "nightly",
with pytest.raises(ValueError): nightly_version="2024.4.0.dev202403271315",
assert bump_version(Version("0.56.0"), "nightly") ) == Version("2024.4.0.dev202403271315")
with pytest.raises(ValueError, match="Can only be run on dev release"):
bump_version(Version("0.56.0"), "nightly")
with pytest.raises(
ValueError, match="Nightly version must have the same release version"
):
bump_version(
Version("0.56.0.dev0"),
"nightly",
nightly_version="2024.4.0.dev202403271315",
)
with pytest.raises(ValueError, match="Nightly version must be a dev version"):
bump_version(Version("0.56.0.dev0"), "nightly", nightly_version="0.56.0")
if __name__ == "__main__": if __name__ == "__main__":