From 1d928f05fa85aa95865134cc1e1f62cb06a3c05f Mon Sep 17 00:00:00 2001 From: Teemu R Date: Sun, 19 Feb 2023 05:39:08 +0100 Subject: [PATCH] Update python-kasa to 0.5.1 (#88416) --- homeassistant/components/tplink/light.py | 9 ++++----- homeassistant/components/tplink/manifest.json | 2 +- requirements_all.txt | 2 +- requirements_test_all.txt | 2 +- tests/components/tplink/test_light.py | 15 ++------------- 5 files changed, 9 insertions(+), 21 deletions(-) diff --git a/homeassistant/components/tplink/light.py b/homeassistant/components/tplink/light.py index 4d7d7a6acc9..6739ea421ba 100644 --- a/homeassistant/components/tplink/light.py +++ b/homeassistant/components/tplink/light.py @@ -232,7 +232,7 @@ class TPLinkSmartBulb(CoordinatedTPLinkEntity, LightEntity): if brightness is not None: await self.device.set_brightness(brightness, transition=transition) return - await self.device.turn_on(transition=transition) # type: ignore[arg-type] + await self.device.turn_on(transition=transition) @async_refresh_after async def async_turn_on(self, **kwargs: Any) -> None: @@ -338,10 +338,9 @@ class TPLinkSmartLightStrip(TPLinkSmartBulb): """Turn the light on.""" brightness, transition = self._async_extract_brightness_transition(**kwargs) if ATTR_EFFECT in kwargs: - await self.device.set_effect(kwargs[ATTR_EFFECT]) - # We need to set the brightness separately until upstream allows defining it for set_effect. - if brightness is not None: - await self._async_turn_on_with_brightness(brightness, transition) + await self.device.set_effect( + kwargs[ATTR_EFFECT], brightness=brightness, transition=transition + ) elif ATTR_COLOR_TEMP in kwargs: if self.effect: # If there is an effect in progress diff --git a/homeassistant/components/tplink/manifest.json b/homeassistant/components/tplink/manifest.json index 0a2a2331cb8..6683e7e4583 100644 --- a/homeassistant/components/tplink/manifest.json +++ b/homeassistant/components/tplink/manifest.json @@ -137,5 +137,5 @@ "iot_class": "local_polling", "loggers": ["kasa"], "quality_scale": "platinum", - "requirements": ["python-kasa==0.5.0"] + "requirements": ["python-kasa==0.5.1"] } diff --git a/requirements_all.txt b/requirements_all.txt index e81b91d64de..89f86d9bd1f 100644 --- a/requirements_all.txt +++ b/requirements_all.txt @@ -2072,7 +2072,7 @@ python-join-api==0.0.9 python-juicenet==1.1.0 # homeassistant.components.tplink -python-kasa==0.5.0 +python-kasa==0.5.1 # homeassistant.components.lirc # python-lirc==1.2.3 diff --git a/requirements_test_all.txt b/requirements_test_all.txt index 0765d13371d..5f62818d278 100644 --- a/requirements_test_all.txt +++ b/requirements_test_all.txt @@ -1471,7 +1471,7 @@ python-izone==1.2.9 python-juicenet==1.1.0 # homeassistant.components.tplink -python-kasa==0.5.0 +python-kasa==0.5.1 # homeassistant.components.matter python-matter-server==2.1.1 diff --git a/tests/components/tplink/test_light.py b/tests/components/tplink/test_light.py index 5a5aff55dc1..b5dc38b230b 100644 --- a/tests/components/tplink/test_light.py +++ b/tests/components/tplink/test_light.py @@ -431,22 +431,11 @@ async def test_smart_strip_effects(hass: HomeAssistant) -> None: {ATTR_ENTITY_ID: entity_id, ATTR_EFFECT: "Effect2"}, blocking=True, ) - strip.set_effect.assert_called_once_with("Effect2") - strip.set_effect.reset_mock() - - # Setting an effect with brightness calls set_brightness implicitly - await hass.services.async_call( - LIGHT_DOMAIN, - "turn_on", - {ATTR_ENTITY_ID: entity_id, ATTR_EFFECT: "Effect2", ATTR_BRIGHTNESS: 255}, - blocking=True, + strip.set_effect.assert_called_once_with( + "Effect2", brightness=None, transition=None ) - strip.set_effect.assert_called_once_with("Effect2") strip.set_effect.reset_mock() - strip.set_brightness.assert_called_with(100, transition=None) - strip.set_brightness.reset_mock() - strip.effect = {"name": "Effect1", "enable": 0, "custom": 0} async_fire_time_changed(hass, dt_util.utcnow() + timedelta(seconds=10)) await hass.async_block_till_done()