From 1de41ab12381e103b8dd34bd2e6e8a3627b4ab30 Mon Sep 17 00:00:00 2001 From: Marc Mueller <30130371+cdce8p@users.noreply.github.com> Date: Tue, 27 Dec 2022 22:44:25 +0100 Subject: [PATCH] Improve DataUpdateCoordinator typing in integrations (1) (#84655) --- homeassistant/components/bmw_connected_drive/coordinator.py | 2 +- homeassistant/components/flux_led/coordinator.py | 2 +- homeassistant/components/fritz/common.py | 2 +- homeassistant/components/ialarm/__init__.py | 2 +- homeassistant/components/lifx/coordinator.py | 2 +- homeassistant/components/nexia/coordinator.py | 2 +- homeassistant/components/rituals_perfume_genie/__init__.py | 2 +- homeassistant/components/skybell/coordinator.py | 2 +- homeassistant/components/tautulli/coordinator.py | 2 +- homeassistant/components/tibber/sensor.py | 2 +- homeassistant/components/tplink/coordinator.py | 2 +- homeassistant/components/volvooncall/__init__.py | 6 +++--- homeassistant/components/wemo/wemo_device.py | 2 +- 13 files changed, 15 insertions(+), 15 deletions(-) diff --git a/homeassistant/components/bmw_connected_drive/coordinator.py b/homeassistant/components/bmw_connected_drive/coordinator.py index 08e90d3c4e0..0f03505ff29 100644 --- a/homeassistant/components/bmw_connected_drive/coordinator.py +++ b/homeassistant/components/bmw_connected_drive/coordinator.py @@ -21,7 +21,7 @@ SCAN_INTERVAL = timedelta(seconds=DEFAULT_SCAN_INTERVAL_SECONDS) _LOGGER = logging.getLogger(__name__) -class BMWDataUpdateCoordinator(DataUpdateCoordinator): +class BMWDataUpdateCoordinator(DataUpdateCoordinator[None]): """Class to manage fetching BMW data.""" account: MyBMWAccount diff --git a/homeassistant/components/flux_led/coordinator.py b/homeassistant/components/flux_led/coordinator.py index 5a7b3c89216..38c5ed70b5e 100644 --- a/homeassistant/components/flux_led/coordinator.py +++ b/homeassistant/components/flux_led/coordinator.py @@ -20,7 +20,7 @@ _LOGGER = logging.getLogger(__name__) REQUEST_REFRESH_DELAY: Final = 2.0 -class FluxLedUpdateCoordinator(DataUpdateCoordinator): +class FluxLedUpdateCoordinator(DataUpdateCoordinator[None]): """DataUpdateCoordinator to gather data for a specific flux_led device.""" def __init__( diff --git a/homeassistant/components/fritz/common.py b/homeassistant/components/fritz/common.py index 28d5cff032d..94053f47284 100644 --- a/homeassistant/components/fritz/common.py +++ b/homeassistant/components/fritz/common.py @@ -136,7 +136,7 @@ class HostInfo(TypedDict): status: bool -class FritzBoxTools(update_coordinator.DataUpdateCoordinator): +class FritzBoxTools(update_coordinator.DataUpdateCoordinator[None]): """FritzBoxTools class.""" def __init__( diff --git a/homeassistant/components/ialarm/__init__.py b/homeassistant/components/ialarm/__init__.py index 374ba29dccf..b258c702725 100644 --- a/homeassistant/components/ialarm/__init__.py +++ b/homeassistant/components/ialarm/__init__.py @@ -54,7 +54,7 @@ async def async_unload_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool: return unload_ok -class IAlarmDataUpdateCoordinator(DataUpdateCoordinator): +class IAlarmDataUpdateCoordinator(DataUpdateCoordinator[None]): """Class to manage fetching iAlarm data.""" def __init__(self, hass: HomeAssistant, ialarm: IAlarm, mac: str) -> None: diff --git a/homeassistant/components/lifx/coordinator.py b/homeassistant/components/lifx/coordinator.py index 1f01f9859c7..952a4574d2d 100644 --- a/homeassistant/components/lifx/coordinator.py +++ b/homeassistant/components/lifx/coordinator.py @@ -64,7 +64,7 @@ class FirmwareEffect(IntEnum): FLAME = 3 -class LIFXUpdateCoordinator(DataUpdateCoordinator): +class LIFXUpdateCoordinator(DataUpdateCoordinator[None]): """DataUpdateCoordinator to gather data for a specific lifx device.""" def __init__( diff --git a/homeassistant/components/nexia/coordinator.py b/homeassistant/components/nexia/coordinator.py index d44e1827f5a..b83ebcf9c40 100644 --- a/homeassistant/components/nexia/coordinator.py +++ b/homeassistant/components/nexia/coordinator.py @@ -14,7 +14,7 @@ _LOGGER = logging.getLogger(__name__) DEFAULT_UPDATE_RATE = 120 -class NexiaDataUpdateCoordinator(DataUpdateCoordinator): +class NexiaDataUpdateCoordinator(DataUpdateCoordinator[None]): """DataUpdateCoordinator for nexia homes.""" def __init__( diff --git a/homeassistant/components/rituals_perfume_genie/__init__.py b/homeassistant/components/rituals_perfume_genie/__init__.py index 441eb04cbe8..a165fc0b2f0 100644 --- a/homeassistant/components/rituals_perfume_genie/__init__.py +++ b/homeassistant/components/rituals_perfume_genie/__init__.py @@ -65,7 +65,7 @@ async def async_unload_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool: return unload_ok -class RitualsDataUpdateCoordinator(DataUpdateCoordinator): +class RitualsDataUpdateCoordinator(DataUpdateCoordinator[None]): """Class to manage fetching Rituals Perfume Genie device data from single endpoint.""" def __init__(self, hass: HomeAssistant, device: Diffuser) -> None: diff --git a/homeassistant/components/skybell/coordinator.py b/homeassistant/components/skybell/coordinator.py index 26545609bd5..55e34df5c63 100644 --- a/homeassistant/components/skybell/coordinator.py +++ b/homeassistant/components/skybell/coordinator.py @@ -11,7 +11,7 @@ from homeassistant.helpers.update_coordinator import DataUpdateCoordinator, Upda from .const import LOGGER -class SkybellDataUpdateCoordinator(DataUpdateCoordinator): +class SkybellDataUpdateCoordinator(DataUpdateCoordinator[None]): """Data update coordinator for the Skybell integration.""" config_entry: ConfigEntry diff --git a/homeassistant/components/tautulli/coordinator.py b/homeassistant/components/tautulli/coordinator.py index a71a7580740..d6e827acd8e 100644 --- a/homeassistant/components/tautulli/coordinator.py +++ b/homeassistant/components/tautulli/coordinator.py @@ -24,7 +24,7 @@ from homeassistant.helpers.update_coordinator import DataUpdateCoordinator, Upda from .const import DOMAIN, LOGGER -class TautulliDataUpdateCoordinator(DataUpdateCoordinator): +class TautulliDataUpdateCoordinator(DataUpdateCoordinator[None]): """Data update coordinator for the Tautulli integration.""" config_entry: ConfigEntry diff --git a/homeassistant/components/tibber/sensor.py b/homeassistant/components/tibber/sensor.py index 3b46129b4c5..fb21ee10aeb 100644 --- a/homeassistant/components/tibber/sensor.py +++ b/homeassistant/components/tibber/sensor.py @@ -553,7 +553,7 @@ class TibberRtDataCoordinator(DataUpdateCoordinator): return self.data.get("data", {}).get("liveMeasurement") -class TibberDataCoordinator(DataUpdateCoordinator): +class TibberDataCoordinator(DataUpdateCoordinator[None]): """Handle Tibber data and insert statistics.""" def __init__(self, hass: HomeAssistant, tibber_connection: tibber.Tibber) -> None: diff --git a/homeassistant/components/tplink/coordinator.py b/homeassistant/components/tplink/coordinator.py index 2b33f817c63..20ec422c372 100644 --- a/homeassistant/components/tplink/coordinator.py +++ b/homeassistant/components/tplink/coordinator.py @@ -15,7 +15,7 @@ _LOGGER = logging.getLogger(__name__) REQUEST_REFRESH_DELAY = 0.35 -class TPLinkDataUpdateCoordinator(DataUpdateCoordinator): +class TPLinkDataUpdateCoordinator(DataUpdateCoordinator[None]): """DataUpdateCoordinator to gather data for a specific TPLink device.""" def __init__( diff --git a/homeassistant/components/volvooncall/__init__.py b/homeassistant/components/volvooncall/__init__.py index 65bc6c1cfbe..b6d97dea216 100644 --- a/homeassistant/components/volvooncall/__init__.py +++ b/homeassistant/components/volvooncall/__init__.py @@ -239,7 +239,7 @@ class VolvoData: raise InvalidAuth from exc -class VolvoUpdateCoordinator(DataUpdateCoordinator): +class VolvoUpdateCoordinator(DataUpdateCoordinator[None]): """Volvo coordinator.""" def __init__(self, hass: HomeAssistant, volvo_data: VolvoData) -> None: @@ -254,14 +254,14 @@ class VolvoUpdateCoordinator(DataUpdateCoordinator): self.volvo_data = volvo_data - async def _async_update_data(self): + async def _async_update_data(self) -> None: """Fetch data from API endpoint.""" async with async_timeout.timeout(10): await self.volvo_data.update() -class VolvoEntity(CoordinatorEntity): +class VolvoEntity(CoordinatorEntity[VolvoUpdateCoordinator]): """Base class for all VOC entities.""" def __init__( diff --git a/homeassistant/components/wemo/wemo_device.py b/homeassistant/components/wemo/wemo_device.py index 826df24a108..56ed9b8e1e6 100644 --- a/homeassistant/components/wemo/wemo_device.py +++ b/homeassistant/components/wemo/wemo_device.py @@ -30,7 +30,7 @@ from .const import DOMAIN, WEMO_SUBSCRIPTION_EVENT _LOGGER = logging.getLogger(__name__) -class DeviceCoordinator(DataUpdateCoordinator): +class DeviceCoordinator(DataUpdateCoordinator[None]): """Home Assistant wrapper for a pyWeMo device.""" def __init__(self, hass: HomeAssistant, wemo: WeMoDevice, device_id: str) -> None: