jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-06-07 06:37:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove deprecated supported features warning in Lock (#132642)

Browse Source
This commit is contained in:
epenet 2024-12-09 08:45:36 +01:00 committed by GitHub
parent 9ef9f2fafb
commit 1ec91e7c89
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 1 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
homeassistant/components/lock/__init__.py
View File

@ -285,12 +285,7 @@ class LockEntity(Entity, cached_properties=CACHED_PROPERTIES_WITH_ATTR_):
@cached_property @cached_property
def supported_features(self) -> LockEntityFeature: def supported_features(self) -> LockEntityFeature:
"""Return the list of supported features.""" """Return the list of supported features."""
features = self._attr_supported_features return self._attr_supported_features
if type(features) is int: # noqa: E721
new_features = LockEntityFeature(features)
self._report_deprecated_supported_features_values(new_features)
return new_features
return features
async def async_internal_added_to_hass(self) -> None: async def async_internal_added_to_hass(self) -> None:
"""Call when the sensor entity is added to hass.""" """Call when the sensor entity is added to hass."""

17
tests/components/lock/test_init.py
View File

@ -417,20 +417,3 @@ def test_deprecated_constants(
import_and_test_deprecated_constant_enum( import_and_test_deprecated_constant_enum(
caplog, lock, enum, constant_prefix, remove_in_version caplog, lock, enum, constant_prefix, remove_in_version
) )
def test_deprecated_supported_features_ints(caplog: pytest.LogCaptureFixture) -> None:
"""Test deprecated supported features ints."""
class MockLockEntity(lock.LockEntity):
_attr_supported_features = 1
entity = MockLockEntity()
assert entity.supported_features is lock.LockEntityFeature(1)
assert "MockLockEntity" in caplog.text
assert "is using deprecated supported features values" in caplog.text
assert "Instead it should use" in caplog.text
assert "LockEntityFeature.OPEN" in caplog.text
caplog.clear()
assert entity.supported_features is lock.LockEntityFeature(1)
assert "is using deprecated supported features values" not in caplog.text