jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-04-23 00:37:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Raise ConditionError for template errors (#46245)

Browse Source
This commit is contained in:
Anders Melchiorsen 2021-02-11 10:30:09 +01:00 committed by GitHub
parent e013ad2413
commit 1f5fb8f28a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
homeassistant/helpers/condition.py
View File

@ -475,8 +475,7 @@ def async_template(
try:
value: str = value_template.async_render(variables, parse_result=False)
except TemplateError as ex:
_LOGGER.error("Error during template condition: %s", ex)
return False
raise ConditionError(f"Error in 'template' condition: {ex}") from ex
return value.lower() == "true"

13
tests/helpers/test_condition.py
View File

@ -1,5 +1,5 @@
"""Test the condition helper."""
from logging import ERROR, WARNING
from logging import WARNING
from unittest.mock import patch
import pytest
@ -1041,19 +1041,14 @@ async def test_extract_devices():
)
async def test_condition_template_error(hass, caplog):
async def test_condition_template_error(hass):
"""Test invalid template."""
caplog.set_level(ERROR)
test = await condition.async_from_config(
hass, {"condition": "template", "value_template": "{{ undefined.state }}"}
)
assert not test(hass)
assert len(caplog.records) == 1
assert caplog.records[0].message.startswith(
"Error during template condition: UndefinedError:"
)
with pytest.raises(ConditionError, match="template"):
test(hass)
async def test_condition_template_invalid_results(hass):