From 1f6f2de9c6a645d5fa5e7ec544d122eac7d547b7 Mon Sep 17 00:00:00 2001 From: magnusknutas Date: Tue, 26 Jan 2016 19:37:53 +0100 Subject: [PATCH] Sorry, I was wrong they are needed --- homeassistant/components/automation/time.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/homeassistant/components/automation/time.py b/homeassistant/components/automation/time.py index 5b8c89b429c..0197ae07d29 100644 --- a/homeassistant/components/automation/time.py +++ b/homeassistant/components/automation/time.py @@ -8,6 +8,7 @@ at https://home-assistant.io/components/automation/#time-trigger """ import logging +from homeassistant.util import convert import homeassistant.util.dt as dt_util from homeassistant.helpers.event import track_time_change @@ -36,6 +37,18 @@ def trigger(hass, config, action): hours = config.get(CONF_HOURS) minutes = config.get(CONF_MINUTES) seconds = config.get(CONF_SECONDS) + if isinstance(minutes, str) and minutes.startswith('/') \ + and not convert(minutes.lstrip('/'), int) % 60 == 0: + _LOGGER.warning('Periodic minutes should be divisible with 60' + 'there will be an offset every hour') + if isinstance(seconds, str) and seconds.startswith('/') \ + and not convert(seconds.lstrip('/'), int) % 60 == 0: + _LOGGER.warning('Periodic seconds should be divisible with 60' + 'there will be an offset every minute') + if isinstance(minutes, str) and hours.startswith('/') \ + and not convert(hours.lstrip('/'), int) % 24 == 0: + _LOGGER.warning('Periodic hours should be divisible with 24' + 'there will be an offset every midnight') else: _LOGGER.error('One of %s, %s, %s OR %s needs to be specified', CONF_HOURS, CONF_MINUTES, CONF_SECONDS, CONF_AFTER)