jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-16 01:37:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve Youtube integration (#93683)

Browse Source 
* Fix feedback

* Fix feedback
This commit is contained in:
Joost Lekkerkerker 2023-05-28 10:52:30 +02:00 committed by GitHub
parent 41882d833d
commit 202c9071a4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
homeassistant/components/youtube/coordinator.py
View File

@ -31,7 +31,8 @@ from .const import (
def get_upload_playlist_id(channel_id: str) -> str: def get_upload_playlist_id(channel_id: str) -> str:
"""Return the playlist id with the uploads of the channel. """Return the playlist id with the uploads of the channel.
Replacing the UC in the channel id (UCxxxxxxxxxxxx) with UU is the way to do it without extra request (UUxxxxxxxxxxxx). Replacing the UC in the channel id (UCxxxxxxxxxxxx) with UU is
the way to do it without extra request (UUxxxxxxxxxxxx).
""" """
return channel_id.replace("UC", "UU", 1) return channel_id.replace("UC", "UU", 1)

6
homeassistant/components/youtube/entity.py
View File

@ -5,13 +5,14 @@ from typing import Any
from homeassistant.const import ATTR_ID from homeassistant.const import ATTR_ID
from homeassistant.helpers.device_registry import DeviceEntryType from homeassistant.helpers.device_registry import DeviceEntryType
from homeassistant.helpers.entity import DeviceInfo, Entity, EntityDescription from homeassistant.helpers.entity import DeviceInfo, EntityDescription
from homeassistant.helpers.update_coordinator import CoordinatorEntity
from .const import ATTR_TITLE, DOMAIN, MANUFACTURER from .const import ATTR_TITLE, DOMAIN, MANUFACTURER
from .coordinator import YouTubeDataUpdateCoordinator from .coordinator import YouTubeDataUpdateCoordinator
class YouTubeChannelEntity(Entity): class YouTubeChannelEntity(CoordinatorEntity):
"""An HA implementation for YouTube entity.""" """An HA implementation for YouTube entity."""
_attr_has_entity_name = True _attr_has_entity_name = True
@ -23,6 +24,7 @@ class YouTubeChannelEntity(Entity):
channel: dict[str, Any], channel: dict[str, Any],
) -> None: ) -> None:
"""Initialize a Google Mail entity.""" """Initialize a Google Mail entity."""
super().__init__(coordinator)
self.entity_description = description self.entity_description = description
self._attr_unique_id = ( self._attr_unique_id = (
f"{coordinator.config_entry.entry_id}_{channel[ATTR_ID]}_{description.key}" f"{coordinator.config_entry.entry_id}_{channel[ATTR_ID]}_{description.key}"

10
homeassistant/components/youtube/strings.json
View File

@ -19,16 +19,6 @@
} }
} }
}, },
"options": {
"step": {
"init": {
"description": "Select the channels you want to add.",
"data": {
"channels": "YouTube channels"
}
}
}
},
"entity": { "entity": {
"sensor": { "sensor": {
"latest_upload": { "latest_upload": {

9
tests/components/youtube/test_sensor.py
View File

@ -1,12 +1,15 @@
"""Sensor tests for the YouTube integration.""" """Sensor tests for the YouTube integration."""
from datetime import timedelta
from unittest.mock import patch from unittest.mock import patch
from google.auth.exceptions import RefreshError from google.auth.exceptions import RefreshError
from homeassistant import config_entries from homeassistant import config_entries
from homeassistant.components.youtube import COORDINATOR, DOMAIN from homeassistant.components.youtube import DOMAIN
from homeassistant.core import HomeAssistant from homeassistant.core import HomeAssistant
from homeassistant.util import dt
from ...common import async_fire_time_changed
from .conftest import TOKEN, ComponentSetup from .conftest import TOKEN, ComponentSetup
@ -40,8 +43,8 @@ async def test_sensor_reauth_trigger(
await setup_integration() await setup_integration()
with patch(TOKEN, side_effect=RefreshError): with patch(TOKEN, side_effect=RefreshError):
entry = hass.config_entries.async_entries(DOMAIN)[0] future = dt.utcnow() + timedelta(minutes=15)
await hass.data[DOMAIN][entry.entry_id][COORDINATOR].async_refresh() async_fire_time_changed(hass, future)
await hass.async_block_till_done() await hass.async_block_till_done()
flows = hass.config_entries.flow.async_progress() flows = hass.config_entries.flow.async_progress()