From 20bacb69189a44e92863f9b2d01660dd908877c3 Mon Sep 17 00:00:00 2001 From: groot406 Date: Sat, 3 Oct 2020 15:02:30 +0200 Subject: [PATCH] Use reference strings for Zoneminder config flow (#41103) --- homeassistant/components/zoneminder/common.py | 4 ++-- homeassistant/components/zoneminder/strings.json | 8 ++++---- tests/components/zoneminder/test_config_flow.py | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/homeassistant/components/zoneminder/common.py b/homeassistant/components/zoneminder/common.py index 970289ea136..9b5498b0cda 100644 --- a/homeassistant/components/zoneminder/common.py +++ b/homeassistant/components/zoneminder/common.py @@ -94,8 +94,8 @@ class ClientAvailabilityResult(Enum): """Client availability test result.""" AVAILABLE = "available" - ERROR_AUTH_FAIL = "auth_fail" - ERROR_CONNECTION_ERROR = "connection_error" + ERROR_AUTH_FAIL = "invalid_auth" + ERROR_CONNECTION_ERROR = "cannot_connect" async def async_test_client_availability( diff --git a/homeassistant/components/zoneminder/strings.json b/homeassistant/components/zoneminder/strings.json index 8b722c9af2c..ef344171442 100644 --- a/homeassistant/components/zoneminder/strings.json +++ b/homeassistant/components/zoneminder/strings.json @@ -16,12 +16,12 @@ } }, "abort": { - "auth_fail": "Username or password is incorrect.", - "connection_error": "Failed to connect to a ZoneMinder server." + "invalid_auth": "[%key:common::config_flow::error::invalid_auth%]", + "cannot_connect": "[%key:common::config_flow::error::cannot_connect%]" }, "error": { - "auth_fail": "Username or password is incorrect.", - "connection_error": "Failed to connect to a ZoneMinder server." + "invalid_auth": "[%key:common::config_flow::error::invalid_auth%]", + "cannot_connect": "[%key:common::config_flow::error::cannot_connect%]" }, "create_entry": { "default": "ZoneMinder server added." } } diff --git a/tests/components/zoneminder/test_config_flow.py b/tests/components/zoneminder/test_config_flow.py index 279613e2b38..d62183cd0f6 100644 --- a/tests/components/zoneminder/test_config_flow.py +++ b/tests/components/zoneminder/test_config_flow.py @@ -45,7 +45,7 @@ async def test_import(hass: HomeAssistant) -> None: ) assert result assert result["type"] == "abort" - assert result["reason"] == "auth_fail" + assert result["reason"] == "invalid_auth" zm_client.login.return_value = True result = await hass.config_entries.flow.async_init(