From 233568ac296d4aae16488d55e40a38e49b536a01 Mon Sep 17 00:00:00 2001 From: Barry Williams Date: Thu, 12 Mar 2020 08:54:25 +0000 Subject: [PATCH] If device has volume disabled, the volume will be `None`. However in these (#32702) instances whenever the volume was requested a division calculation was made resulting in a TypeError. The volume adjustment from `0-100` to `0-1` is now calculated during the `update()` method. --- homeassistant/components/openhome/media_player.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/homeassistant/components/openhome/media_player.py b/homeassistant/components/openhome/media_player.py index 5d6ee47c3eb..967bce6007e 100644 --- a/homeassistant/components/openhome/media_player.py +++ b/homeassistant/components/openhome/media_player.py @@ -85,7 +85,7 @@ class OpenhomeDevice(MediaPlayerDevice): self._supported_features |= ( SUPPORT_VOLUME_STEP | SUPPORT_VOLUME_MUTE | SUPPORT_VOLUME_SET ) - self._volume_level = self._device.VolumeLevel() + self._volume_level = self._device.VolumeLevel() / 100.0 self._volume_muted = self._device.IsMuted() for source in self._device.Sources(): @@ -222,7 +222,7 @@ class OpenhomeDevice(MediaPlayerDevice): @property def volume_level(self): """Volume level of the media player (0..1).""" - return self._volume_level / 100.0 + return self._volume_level @property def is_volume_muted(self):