jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-27 15:17:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Speed up history get_states (#23881)

Browse Source 
* Speed up history `get_states`

Adding a boundary of the start of the recorder run the point is in, significantly increases the time of the query. This speeds up the fetching of the history of 1 entity.

* Make single entity query easier

no need for joins with single entity

* Lint
This commit is contained in:
Bram Kragten 2019-08-25 21:11:12 +02:00 committed by Pascal Vizeli
parent 7bfb365f62
commit 248619a036
1 changed files with 13 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
homeassistant/components/history/__init__.py
View File

@ -154,20 +154,21 @@ def get_states(hass, utc_point_in_time, entity_ids=None, run=None, filters=None)
from sqlalchemy import and_, func from sqlalchemy import and_, func
with session_scope(hass=hass) as session: with session_scope(hass=hass) as session:
query = session.query(States)
if entity_ids and len(entity_ids) == 1: if entity_ids and len(entity_ids) == 1:
# Use an entirely different (and extremely fast) query if we only # Use an entirely different (and extremely fast) query if we only
# have a single entity id # have a single entity id
most_recent_state_ids = ( query = (
session.query(States.state_id.label("max_state_id")) query.filter(
.filter( States.last_updated >= run.start,
(States.last_updated < utc_point_in_time) States.last_updated < utc_point_in_time,
& (States.entity_id.in_(entity_ids)) States.entity_id.in_(entity_ids),
) )
.order_by(States.last_updated.desc()) .order_by(States.last_updated.desc())
.limit(1)
) )
most_recent_state_ids = most_recent_state_ids.limit(1)
else: else:
# We have more than one entity to look at (most commonly we want # We have more than one entity to look at (most commonly we want
# all entities,) so we need to do a search on all states since the # all entities,) so we need to do a search on all states since the
@ -203,19 +204,15 @@ def get_states(hass, utc_point_in_time, entity_ids=None, run=None, filters=None)
most_recent_state_ids = most_recent_state_ids.group_by(States.entity_id) most_recent_state_ids = most_recent_state_ids.group_by(States.entity_id)
most_recent_state_ids = most_recent_state_ids.subquery() most_recent_state_ids = most_recent_state_ids.subquery()
query = ( query = query.join(
session.query(States)
.join(
most_recent_state_ids, most_recent_state_ids,
States.state_id == most_recent_state_ids.c.max_state_id, States.state_id == most_recent_state_ids.c.max_state_id,
) ).filter(~States.domain.in_(IGNORE_DOMAINS))
.filter((~States.domain.in_(IGNORE_DOMAINS)))
)
if filters: if filters:
query = filters.apply(query, entity_ids) query = filters.apply(query, entity_ids)
return [ return [
state state