jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-11-13 13:00:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reolink change ir to switch (#105916)

Browse Source 
* Change IR from light to switch

* Remove old entity

* Add test

* Apply suggestions from code review

Co-authored-by: Jan-Philipp Benecke <github@bnck.me>

---------

Co-authored-by: Jan-Philipp Benecke <github@bnck.me>
This commit is contained in:
starkillerOG
2023-12-18 11:13:20 +01:00
committed by GitHub
parent 3e50ca6cda
commit 253182c650
5 changed files with 58 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
tests/components/reolink/test_init.py
View File

@@ -19,7 +19,7 @@ from homeassistant.helpers import (
from homeassistant.setup import async_setup_component
from homeassistant.util.dt import utcnow
from .conftest import TEST_CAM_MODEL, TEST_HOST_MODEL, TEST_NVR_NAME
from .conftest import TEST_CAM_MODEL, TEST_HOST_MODEL, TEST_MAC, TEST_NVR_NAME
from tests.common import MockConfigEntry, async_fire_time_changed
@@ -172,6 +172,42 @@ async def test_cleanup_disconnected_cams(
assert sorted(device_models) == sorted(expected_models)
async def test_cleanup_deprecated_entities(
hass: HomeAssistant,
config_entry: MockConfigEntry,
reolink_connect: MagicMock,
entity_registry: er.EntityRegistry,
) -> None:
"""Test deprecated ir_lights light entity is cleaned."""
reolink_connect.channels = [0]
ir_id = f"{TEST_MAC}_0_ir_lights"
entity_registry.async_get_or_create(
domain=Platform.LIGHT,
platform=const.DOMAIN,
unique_id=ir_id,
config_entry=config_entry,
suggested_object_id=ir_id,
disabled_by=None,
)
assert entity_registry.async_get_entity_id(Platform.LIGHT, const.DOMAIN, ir_id)
assert (
entity_registry.async_get_entity_id(Platform.SWITCH, const.DOMAIN, ir_id)
is None
)
# setup CH 0 and NVR switch entities/device
with patch("homeassistant.components.reolink.PLATFORMS", [Platform.SWITCH]):
assert await hass.config_entries.async_setup(config_entry.entry_id)
await hass.async_block_till_done()
assert (
entity_registry.async_get_entity_id(Platform.LIGHT, const.DOMAIN, ir_id) is None
)
assert entity_registry.async_get_entity_id(Platform.SWITCH, const.DOMAIN, ir_id)
async def test_no_repair_issue(
hass: HomeAssistant, config_entry: MockConfigEntry
) -> None: