From 259455b32dc4ceacd3479e70e2c68e128407d30e Mon Sep 17 00:00:00 2001
From: Joost Lekkerkerker <joostlek@outlook.com>
Date: Mon, 3 Jul 2023 03:36:27 +0200
Subject: [PATCH] Add entity translations to melnor (#95734)

---
 homeassistant/components/melnor/number.py    |  6 ++--
 homeassistant/components/melnor/sensor.py    |  7 ++--
 homeassistant/components/melnor/strings.json | 34 ++++++++++++++++++++
 homeassistant/components/melnor/switch.py    |  2 +-
 homeassistant/components/melnor/time.py      |  2 +-
 5 files changed, 42 insertions(+), 9 deletions(-)

diff --git a/homeassistant/components/melnor/number.py b/homeassistant/components/melnor/number.py
index 79b80a6d7b5..e0f9c7d3bf6 100644
--- a/homeassistant/components/melnor/number.py
+++ b/homeassistant/components/melnor/number.py
@@ -48,7 +48,7 @@ ZONE_ENTITY_DESCRIPTIONS: list[MelnorZoneNumberEntityDescription] = [
         native_min_value=1,
         icon="mdi:timer-cog-outline",
         key="manual_minutes",
-        name="Manual Duration",
+        translation_key="manual_minutes",
         native_unit_of_measurement=UnitOfTime.MINUTES,
         set_num_fn=lambda valve, value: valve.set_manual_watering_minutes(value),
         state_fn=lambda valve: valve.manual_watering_minutes,
@@ -59,7 +59,7 @@ ZONE_ENTITY_DESCRIPTIONS: list[MelnorZoneNumberEntityDescription] = [
         native_min_value=1,
         icon="mdi:calendar-refresh-outline",
         key="frequency_interval_hours",
-        name="Schedule Interval",
+        translation_key="frequency_interval_hours",
         native_unit_of_measurement=UnitOfTime.HOURS,
         set_num_fn=lambda valve, value: valve.set_frequency_interval_hours(value),
         state_fn=lambda valve: valve.frequency.interval_hours,
@@ -70,7 +70,7 @@ ZONE_ENTITY_DESCRIPTIONS: list[MelnorZoneNumberEntityDescription] = [
         native_min_value=1,
         icon="mdi:timer-outline",
         key="frequency_duration_minutes",
-        name="Schedule Duration",
+        translation_key="frequency_duration_minutes",
         native_unit_of_measurement=UnitOfTime.MINUTES,
         set_num_fn=lambda valve, value: valve.set_frequency_duration_minutes(value),
         state_fn=lambda valve: valve.frequency.duration_minutes,
diff --git a/homeassistant/components/melnor/sensor.py b/homeassistant/components/melnor/sensor.py
index b4a1d44a291..edb906cc80f 100644
--- a/homeassistant/components/melnor/sensor.py
+++ b/homeassistant/components/melnor/sensor.py
@@ -87,7 +87,6 @@ DEVICE_ENTITY_DESCRIPTIONS: list[MelnorSensorEntityDescription] = [
         device_class=SensorDeviceClass.BATTERY,
         entity_category=EntityCategory.DIAGNOSTIC,
         key="battery",
-        name="Battery",
         native_unit_of_measurement=PERCENTAGE,
         state_class=SensorStateClass.MEASUREMENT,
         state_fn=lambda device: device.battery_level,
@@ -97,7 +96,7 @@ DEVICE_ENTITY_DESCRIPTIONS: list[MelnorSensorEntityDescription] = [
         entity_category=EntityCategory.DIAGNOSTIC,
         entity_registry_enabled_default=False,
         key="rssi",
-        name="RSSI",
+        translation_key="rssi",
         native_unit_of_measurement=SIGNAL_STRENGTH_DECIBELS_MILLIWATT,
         state_class=SensorStateClass.MEASUREMENT,
         state_fn=lambda device: device.rssi,
@@ -108,13 +107,13 @@ ZONE_ENTITY_DESCRIPTIONS: list[MelnorZoneSensorEntityDescription] = [
     MelnorZoneSensorEntityDescription(
         device_class=SensorDeviceClass.TIMESTAMP,
         key="manual_cycle_end",
-        name="Manual Cycle End",
+        translation_key="manual_cycle_end",
         state_fn=watering_seconds_left,
     ),
     MelnorZoneSensorEntityDescription(
         device_class=SensorDeviceClass.TIMESTAMP,
         key="next_cycle",
-        name="Next Cycle",
+        translation_key="next_cycle",
         state_fn=next_cycle,
     ),
 ]
diff --git a/homeassistant/components/melnor/strings.json b/homeassistant/components/melnor/strings.json
index 2fefa32b6bc..51ca18b0b3d 100644
--- a/homeassistant/components/melnor/strings.json
+++ b/homeassistant/components/melnor/strings.json
@@ -10,5 +10,39 @@
         "title": "Discovered Melnor Bluetooth valve"
       }
     }
+  },
+  "entity": {
+    "number": {
+      "manual_minutes": {
+        "name": "Manual duration"
+      },
+      "frequency_interval_hours": {
+        "name": "Schedule interval"
+      },
+      "frequency_duration_minutes": {
+        "name": "Schedule duration"
+      }
+    },
+    "sensor": {
+      "rssi": {
+        "name": "RSSI"
+      },
+      "manual_cycle_end": {
+        "name": "Manual cycle end"
+      },
+      "next_cycle": {
+        "name": "Next cycle"
+      }
+    },
+    "switch": {
+      "frequency": {
+        "name": "Schedule"
+      }
+    },
+    "time": {
+      "frequency_start_time": {
+        "name": "Schedule start time"
+      }
+    }
   }
 }
diff --git a/homeassistant/components/melnor/switch.py b/homeassistant/components/melnor/switch.py
index e5f70bc25a0..03bd28faa9d 100644
--- a/homeassistant/components/melnor/switch.py
+++ b/homeassistant/components/melnor/switch.py
@@ -53,7 +53,7 @@ ZONE_ENTITY_DESCRIPTIONS = [
         device_class=SwitchDeviceClass.SWITCH,
         icon="mdi:calendar-sync-outline",
         key="frequency",
-        name="Schedule",
+        translation_key="frequency",
         on_off_fn=lambda valve, bool: valve.set_frequency_enabled(bool),
         state_fn=lambda valve: valve.schedule_enabled,
     ),
diff --git a/homeassistant/components/melnor/time.py b/homeassistant/components/melnor/time.py
index 7abdf62e20c..943a7996aeb 100644
--- a/homeassistant/components/melnor/time.py
+++ b/homeassistant/components/melnor/time.py
@@ -42,7 +42,7 @@ ZONE_ENTITY_DESCRIPTIONS: list[MelnorZoneTimeEntityDescription] = [
     MelnorZoneTimeEntityDescription(
         entity_category=EntityCategory.CONFIG,
         key="frequency_start_time",
-        name="Schedule Start Time",
+        translation_key="frequency_start_time",
         set_time_fn=lambda valve, value: valve.set_frequency_start_time(value),
         state_fn=lambda valve: valve.frequency.start_time,
     ),