jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-13 00:07:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ignore duplicate state changes GarageDoor HomeKit (#18149)

Browse Source 
* Ignore duplicate state changes GarageDoor HomeKit

* Don't ignore service_call
This commit is contained in:
cdce8p 2018-11-05 16:42:19 +01:00 committed by Paulus Schoutsen
parent dcdae325ea
commit 26ba4a56e8
2 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
homeassistant/components/homekit/type_covers.py
View File

@ -46,10 +46,12 @@ class GarageDoorOpener(HomeAccessory):
params = {ATTR_ENTITY_ID: self.entity_id} params = {ATTR_ENTITY_ID: self.entity_id}
if value == 0: if value == 0:
self.char_current_state.set_value(3) if self.char_current_state.value != value:
self.char_current_state.set_value(3)
self.call_service(DOMAIN, SERVICE_OPEN_COVER, params) self.call_service(DOMAIN, SERVICE_OPEN_COVER, params)
elif value == 1: elif value == 1:
self.char_current_state.set_value(2) if self.char_current_state.value != value:
self.char_current_state.set_value(2)
self.call_service(DOMAIN, SERVICE_CLOSE_COVER, params) self.call_service(DOMAIN, SERVICE_CLOSE_COVER, params)
def update_state(self, new_state): def update_state(self, new_state):

19
tests/components/homekit/test_type_covers.py
View File

@ -80,13 +80,30 @@ async def test_garage_door_open_close(hass, hk_driver, cls, events):
hass.states.async_set(entity_id, STATE_CLOSED) hass.states.async_set(entity_id, STATE_CLOSED)
await hass.async_block_till_done() await hass.async_block_till_done()
await hass.async_add_job(acc.char_target_state.client_update_value, 1)
await hass.async_block_till_done()
assert acc.char_current_state.value == 1
assert acc.char_target_state.value == 1
assert len(events) == 2
assert events[-1].data[ATTR_VALUE] is None
await hass.async_add_job(acc.char_target_state.client_update_value, 0) await hass.async_add_job(acc.char_target_state.client_update_value, 0)
await hass.async_block_till_done() await hass.async_block_till_done()
assert call_open_cover assert call_open_cover
assert call_open_cover[0].data[ATTR_ENTITY_ID] == entity_id assert call_open_cover[0].data[ATTR_ENTITY_ID] == entity_id
assert acc.char_current_state.value == 3 assert acc.char_current_state.value == 3
assert acc.char_target_state.value == 0 assert acc.char_target_state.value == 0
assert len(events) == 2 assert len(events) == 3
assert events[-1].data[ATTR_VALUE] is None
hass.states.async_set(entity_id, STATE_OPEN)
await hass.async_block_till_done()
await hass.async_add_job(acc.char_target_state.client_update_value, 0)
await hass.async_block_till_done()
assert acc.char_current_state.value == 0
assert acc.char_target_state.value == 0
assert len(events) == 4
assert events[-1].data[ATTR_VALUE] is None assert events[-1].data[ATTR_VALUE] is None