From 2749ca4ef4cec399d8d1d1b5158d21995dbb3d77 Mon Sep 17 00:00:00 2001 From: Colin O'Dell Date: Sat, 28 Apr 2018 05:39:45 -0500 Subject: [PATCH] Update QNAP lib to 0.2.6; handle null temps gracefully (#14117) There's one particular QNAP model which sometimes return empty/null temperatures for certain disks. This commit ensures that this model can be integrated with HASS without causing KeyErrors or other exceptions - if this edge case is hit, the sensor will simply show `0` instead. --- homeassistant/components/sensor/qnap.py | 4 ++-- requirements_all.txt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/homeassistant/components/sensor/qnap.py b/homeassistant/components/sensor/qnap.py index 629a5f6a0ee..b3ca054f88f 100644 --- a/homeassistant/components/sensor/qnap.py +++ b/homeassistant/components/sensor/qnap.py @@ -17,7 +17,7 @@ from homeassistant.const import ( from homeassistant.util import Throttle import homeassistant.helpers.config_validation as cv -REQUIREMENTS = ['qnapstats==0.2.5'] +REQUIREMENTS = ['qnapstats==0.2.6'] _LOGGER = logging.getLogger(__name__) @@ -352,7 +352,7 @@ class QNAPDriveSensor(QNAPSensor): return data['health'] if self.var_id == 'drive_temp': - return int(data['temp_c']) + return int(data['temp_c']) if data['temp_c'] is not None else 0 @property def name(self): diff --git a/requirements_all.txt b/requirements_all.txt index 91b6c71eaa1..b277e638bd9 100644 --- a/requirements_all.txt +++ b/requirements_all.txt @@ -1099,7 +1099,7 @@ pyxeoma==1.4.0 pyzabbix==0.7.4 # homeassistant.components.sensor.qnap -qnapstats==0.2.5 +qnapstats==0.2.6 # homeassistant.components.switch.rachio rachiopy==0.1.2