jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-25 14:17:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Limit number of processed entries by Feedreader (#1966)

Browse Source 
* process only last 20 available entries to avoid bombing event
  bus when parsing huge feeds
* trigger first update only when HA has completed startup,
  allowing components to complete subscriptions to feedreader
  events
* quote url in logs for better readability
This commit is contained in:
Alexander Fortin 2016-05-04 03:40:30 +02:00 committed by Paulus Schoutsen
parent 6d9254ce25
commit 298b9d1f12
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
homeassistant/components/feedreader.py
View File

@ -7,6 +7,7 @@ https://home-assistant.io/components/feedreader/
from datetime import datetime from datetime import datetime
from logging import getLogger from logging import getLogger
import voluptuous as vol import voluptuous as vol
from homeassistant.const import EVENT_HOMEASSISTANT_START
from homeassistant.helpers.event import track_utc_time_change from homeassistant.helpers.event import track_utc_time_change
REQUIREMENTS = ['feedparser==5.2.1'] REQUIREMENTS = ['feedparser==5.2.1']
@ -19,6 +20,7 @@ CONFIG_SCHEMA = vol.Schema({
'urls': [vol.Url()], 'urls': [vol.Url()],
} }
}, extra=vol.ALLOW_EXTRA) }, extra=vol.ALLOW_EXTRA)
MAX_ENTRIES = 20
# pylint: disable=too-few-public-methods # pylint: disable=too-few-public-methods
@ -33,17 +35,17 @@ class FeedManager(object):
self._firstrun = True self._firstrun = True
# Initialize last entry timestamp as epoch time # Initialize last entry timestamp as epoch time
self._last_entry_timestamp = datetime.utcfromtimestamp(0).timetuple() self._last_entry_timestamp = datetime.utcfromtimestamp(0).timetuple()
_LOGGER.debug('Loading feed %s', self._url) hass.bus.listen_once(EVENT_HOMEASSISTANT_START,
self._update() lambda _: self._update())
track_utc_time_change(hass, lambda now: self._update(), track_utc_time_change(hass, lambda now: self._update(),
minute=0, second=0) minute=0, second=0)
def _log_no_entries(self): def _log_no_entries(self):
"""Send no entries log at debug level.""" """Send no entries log at debug level."""
_LOGGER.debug('No new entries in feed %s', self._url) _LOGGER.debug('No new entries in feed "%s"', self._url)
def _update(self): def _update(self):
"""Update the feed and publish new entries in the event bus.""" """Update the feed and publish new entries to the event bus."""
import feedparser import feedparser
_LOGGER.info('Fetching new data from feed "%s"', self._url) _LOGGER.info('Fetching new data from feed "%s"', self._url)
self._feed = feedparser.parse(self._url, self._feed = feedparser.parse(self._url,
@ -52,16 +54,20 @@ class FeedManager(object):
modified=None if not self._feed modified=None if not self._feed
else self._feed.get('modified')) else self._feed.get('modified'))
if not self._feed: if not self._feed:
_LOGGER.error('Error fetching feed data from %s', self._url) _LOGGER.error('Error fetching feed data from "%s"', self._url)
else: else:
if self._feed.bozo != 0: if self._feed.bozo != 0:
_LOGGER.error('Error parsing feed %s', self._url) _LOGGER.error('Error parsing feed "%s"', self._url)
# Using etag and modified, if there's no new data available, # Using etag and modified, if there's no new data available,
# the entries list will be empty # the entries list will be empty
elif len(self._feed.entries) > 0: elif len(self._feed.entries) > 0:
_LOGGER.debug('%s entri(es) available in feed %s', _LOGGER.debug('%s entri(es) available in feed "%s"',
len(self._feed.entries), len(self._feed.entries),
self._url) self._url)
if len(self._feed.entries) > MAX_ENTRIES:
_LOGGER.debug('Publishing only the first %s entries '
'in feed "%s"', MAX_ENTRIES, self._url)
self._feed.entries = self._feed.entries[0:MAX_ENTRIES]
self._publish_new_entries() self._publish_new_entries()
else: else:
self._log_no_entries() self._log_no_entries()
@ -91,7 +97,7 @@ class FeedManager(object):
self._update_and_fire_entry(entry) self._update_and_fire_entry(entry)
new_entries = True new_entries = True
else: else:
_LOGGER.debug('Entry %s already processed', entry.title) _LOGGER.debug('Entry "%s" already processed', entry.title)
if not new_entries: if not new_entries:
self._log_no_entries() self._log_no_entries()
self._firstrun = False self._firstrun = False