jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-18 18:57:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve version sensor (#18292)

Browse Source 
* Validate value against valid list

* Show correct name

Constants in alphabetical order.
Added default name when not showing the local/current version.

* Add icon

Icon was already defined but not set

* Unnecessary "elif" after "return" (no-else-return)
This commit is contained in:
Jorim Tielemans 2018-11-07 13:28:25 +01:00 committed by Daniel Høyer Iversen
parent ec732c896d
commit 29be78e08e
1 changed files with 25 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
homeassistant/components/sensor/version.py
View File

@ -20,11 +20,21 @@ REQUIREMENTS = ['pyhaversion==2.0.1']
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
ALL_IMAGES = [
'default', 'intel-nuc', 'qemux86', 'qemux86-64', 'qemuarm',
'qemuarm-64', 'raspberrypi', 'raspberrypi2', 'raspberrypi3',
'raspberrypi3-64', 'tinker', 'odroid-c2', 'odroid-xu'
]
ALL_SOURCES = [
'local', 'pypi', 'hassio', 'docker'
]
CONF_BETA = 'beta' CONF_BETA = 'beta'
CONF_IMAGE = 'image' CONF_IMAGE = 'image'
DEFAULT_IMAGE = 'default' DEFAULT_IMAGE = 'default'
DEFAULT_NAME = "Current Version" DEFAULT_NAME_LATEST = "Latest Version"
DEFAULT_NAME_LOCAL = "Current Version"
DEFAULT_SOURCE = 'local' DEFAULT_SOURCE = 'local'
ICON = 'mdi:package-up' ICON = 'mdi:package-up'
@ -33,11 +43,9 @@ TIME_BETWEEN_UPDATES = timedelta(minutes=5)
PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({ PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({
vol.Optional(CONF_BETA, default=False): cv.boolean, vol.Optional(CONF_BETA, default=False): cv.boolean,
vol.Optional(CONF_IMAGE, default=DEFAULT_IMAGE): vol.All(cv.string, vol.Optional(CONF_IMAGE, default=DEFAULT_IMAGE): vol.In(ALL_IMAGES),
vol.Lower), vol.Optional(CONF_NAME, default=''): cv.string,
vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string, vol.Optional(CONF_SOURCE, default=DEFAULT_SOURCE): vol.In(ALL_SOURCES),
vol.Optional(CONF_SOURCE, default=DEFAULT_SOURCE): vol.All(cv.string,
vol.Lower),
}) })
@ -63,7 +71,7 @@ async def async_setup_platform(
class VersionSensor(Entity): class VersionSensor(Entity):
"""Representation of a Home Assistant version sensor.""" """Representation of a Home Assistant version sensor."""
def __init__(self, haversion, name): def __init__(self, haversion, name=''):
"""Initialize the Version sensor.""" """Initialize the Version sensor."""
self.haversion = haversion self.haversion = haversion
self._name = name self._name = name
@ -76,7 +84,11 @@ class VersionSensor(Entity):
@property @property
def name(self): def name(self):
"""Return the name of the sensor.""" """Return the name of the sensor."""
return self._name if self._name:
return self._name
if self.haversion.source == DEFAULT_SOURCE:
return DEFAULT_NAME_LOCAL
return DEFAULT_NAME_LATEST
@property @property
def state(self): def state(self):
@ -88,6 +100,11 @@ class VersionSensor(Entity):
"""Return attributes for the sensor.""" """Return attributes for the sensor."""
return self.haversion.api.version_data return self.haversion.api.version_data
@property
def icon(self):
"""Return the icon to use in the frontend, if any."""
return ICON
class VersionData: class VersionData:
"""Get the latest data and update the states.""" """Get the latest data and update the states."""