From 2a4ed9ace7853290c3918b389f7e349003ab0703 Mon Sep 17 00:00:00 2001
From: Luke Lashley <conway220@gmail.com>
Date: Thu, 20 Mar 2025 10:14:45 -0400
Subject: [PATCH] Add translations for Roborock Exceptions (#140964)

* Add translations to a few exceptions

* match existing wording

* fix regex

* consolidate errors

* fix test
---
 homeassistant/components/roborock/coordinator.py     | 12 ++++++++++--
 homeassistant/components/roborock/quality_scale.yaml |  2 +-
 homeassistant/components/roborock/strings.json       |  6 ++++++
 homeassistant/components/roborock/vacuum.py          |  9 +++++++--
 tests/components/roborock/test_vacuum.py             |  4 +++-
 5 files changed, 27 insertions(+), 6 deletions(-)

diff --git a/homeassistant/components/roborock/coordinator.py b/homeassistant/components/roborock/coordinator.py
index 698e2c268ed..6d0c9737a29 100644
--- a/homeassistant/components/roborock/coordinator.py
+++ b/homeassistant/components/roborock/coordinator.py
@@ -193,7 +193,12 @@ class RoborockDataUpdateCoordinator(DataUpdateCoordinator[DeviceProp]):
         try:
             maps = await self.api.get_multi_maps_list()
         except RoborockException as err:
-            raise UpdateFailed("Failed to get map data: {err}") from err
+            _LOGGER.debug("Failed to get maps: %s", err)
+            raise UpdateFailed(
+                translation_domain=DOMAIN,
+                translation_key="map_failure",
+                translation_placeholders={"error": str(err)},
+            ) from err
         # Rooms names populated later with calls to `set_current_map_rooms` for each map
         roborock_maps = maps.map_info if (maps and maps.map_info) else ()
         stored_images = await asyncio.gather(
@@ -310,7 +315,10 @@ class RoborockDataUpdateCoordinator(DataUpdateCoordinator[DeviceProp]):
             await self.set_current_map_rooms()
         except RoborockException as ex:
             _LOGGER.debug("Failed to update data: %s", ex)
-            raise UpdateFailed(ex) from ex
+            raise UpdateFailed(
+                translation_domain=DOMAIN,
+                translation_key="update_data_fail",
+            ) from ex
         if self.roborock_device_info.props.status.in_cleaning:
             if self._is_cloud_api:
                 self.update_interval = V1_CLOUD_IN_CLEANING_INTERVAL
diff --git a/homeassistant/components/roborock/quality_scale.yaml b/homeassistant/components/roborock/quality_scale.yaml
index c7675ef96d1..feee5cb434c 100644
--- a/homeassistant/components/roborock/quality_scale.yaml
+++ b/homeassistant/components/roborock/quality_scale.yaml
@@ -64,7 +64,7 @@ rules:
     status: exempt
     comment: There are no noisy entities.
   entity-translations: done
-  exception-translations: todo
+  exception-translations: done
   icon-translations: todo
   reconfiguration-flow: todo
   repair-issues:
diff --git a/homeassistant/components/roborock/strings.json b/homeassistant/components/roborock/strings.json
index a59dc80e65d..caad67e4ce6 100644
--- a/homeassistant/components/roborock/strings.json
+++ b/homeassistant/components/roborock/strings.json
@@ -457,6 +457,12 @@
     "map_failure": {
       "message": "Something went wrong creating the map"
     },
+    "position_not_found": {
+      "message": "Robot position not found"
+    },
+    "update_data_fail": {
+      "message": "Failed to update data"
+    },
     "no_coordinators": {
       "message": "No devices were able to successfully setup"
     },
diff --git a/homeassistant/components/roborock/vacuum.py b/homeassistant/components/roborock/vacuum.py
index c5357597527..058fffbdb1c 100644
--- a/homeassistant/components/roborock/vacuum.py
+++ b/homeassistant/components/roborock/vacuum.py
@@ -221,13 +221,18 @@ class RoborockVacuum(RoborockCoordinatedEntityV1, StateVacuumEntity):
 
         map_data = await self.coordinator.cloud_api.get_map_v1()
         if not isinstance(map_data, bytes):
-            raise HomeAssistantError("Failed to retrieve map data.")
+            raise HomeAssistantError(
+                translation_domain=DOMAIN,
+                translation_key="map_failure",
+            )
         parser = RoborockMapDataParser(ColorsPalette(), Sizes(), [], ImageConfig(), [])
         parsed_map = parser.parse(map_data)
         robot_position = parsed_map.vacuum_position
 
         if robot_position is None:
-            raise HomeAssistantError("Robot position not found")
+            raise HomeAssistantError(
+                translation_domain=DOMAIN, translation_key="position_not_found"
+            )
 
         return {
             "x": robot_position.x,
diff --git a/tests/components/roborock/test_vacuum.py b/tests/components/roborock/test_vacuum.py
index 2a2d9f210ed..5d6e7a599bd 100644
--- a/tests/components/roborock/test_vacuum.py
+++ b/tests/components/roborock/test_vacuum.py
@@ -291,7 +291,9 @@ async def test_get_current_position_no_map_data(
             "homeassistant.components.roborock.coordinator.RoborockMqttClientV1.get_map_v1",
             return_value=None,
         ),
-        pytest.raises(HomeAssistantError, match="Failed to retrieve map data."),
+        pytest.raises(
+            HomeAssistantError, match="Something went wrong creating the map"
+        ),
     ):
         await hass.services.async_call(
             DOMAIN,