From 2ad0fd1ce11a33ffc0333dadb158c0cd7f422607 Mon Sep 17 00:00:00 2001
From: Raman Gupta <7243222+raman325@users.noreply.github.com>
Date: Tue, 19 Sep 2023 11:30:38 -0400
Subject: [PATCH] Adjust hassfest.manifest based on config.action (#100577)

---
 script/hassfest/manifest.py | 14 +++++++++-----
 script/hassfest/model.py    |  4 ++--
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/script/hassfest/manifest.py b/script/hassfest/manifest.py
index 9323b8e86c0..acdea23444d 100644
--- a/script/hassfest/manifest.py
+++ b/script/hassfest/manifest.py
@@ -366,15 +366,19 @@ def _sort_manifest_keys(key: str) -> str:
     return _SORT_KEYS.get(key, key)
 
 
-def sort_manifest(integration: Integration) -> bool:
+def sort_manifest(integration: Integration, config: Config) -> bool:
     """Sort manifest."""
     keys = list(integration.manifest.keys())
     if (keys_sorted := sorted(keys, key=_sort_manifest_keys)) != keys:
         manifest = {key: integration.manifest[key] for key in keys_sorted}
-        integration.manifest_path.write_text(json.dumps(manifest, indent=2))
+        if config.action == "generate":
+            integration.manifest_path.write_text(json.dumps(manifest, indent=2))
+            text = "have been sorted"
+        else:
+            text = "are not sorted correctly"
         integration.add_error(
             "manifest",
-            "Manifest keys have been sorted: domain, name, then alphabetical order",
+            f"Manifest keys {text}: domain, name, then alphabetical order",
         )
         return True
     return False
@@ -387,9 +391,9 @@ def validate(integrations: dict[str, Integration], config: Config) -> None:
     for integration in integrations.values():
         validate_manifest(integration, core_components_dir)
         if not integration.errors:
-            if sort_manifest(integration):
+            if sort_manifest(integration, config):
                 manifests_resorted.append(integration.manifest_path)
-    if manifests_resorted:
+    if config.action == "generate" and manifests_resorted:
         subprocess.run(
             ["pre-commit", "run", "--hook-stage", "manual", "prettier", "--files"]
             + manifests_resorted,
diff --git a/script/hassfest/model.py b/script/hassfest/model.py
index e4f93c80e81..7df65b8221e 100644
--- a/script/hassfest/model.py
+++ b/script/hassfest/model.py
@@ -4,7 +4,7 @@ from __future__ import annotations
 from dataclasses import dataclass, field
 import json
 import pathlib
-from typing import Any
+from typing import Any, Literal
 
 
 @dataclass
@@ -26,7 +26,7 @@ class Config:
 
     specific_integrations: list[pathlib.Path] | None
     root: pathlib.Path
-    action: str
+    action: Literal["validate", "generate"]
     requirements: bool
     errors: list[Error] = field(default_factory=list)
     cache: dict[str, Any] = field(default_factory=dict)