jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-17 18:27:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't try and store exceptions when the key is missing (#41803)

Browse Source
This commit is contained in:
Tom Parker-Shemilt 2020-10-16 09:01:58 +01:00 committed by GitHub
parent 8bc47c0cd1
commit 2b151209b2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/conftest.py
View File

@ -109,7 +109,18 @@ def hass(loop, hass_storage, request):
def exc_handle(loop, context): def exc_handle(loop, context):
"""Handle exceptions by rethrowing them, which will fail the test.""" """Handle exceptions by rethrowing them, which will fail the test."""
# Most of these contexts will contain an exception, but not all.
# The docs note the key as "optional"
# See https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.call_exception_handler
if "exception" in context:
exceptions.append(context["exception"]) exceptions.append(context["exception"])
else:
exceptions.append(
Exception(
"Received exception handler without exception, but with message: %s"
% context["message"]
)
)
orig_exception_handler(loop, context) orig_exception_handler(loop, context)
exceptions = [] exceptions = []

2
tests/ignore_uncaught_exceptions.py
View File

@ -16,4 +16,6 @@ IGNORE_UNCAUGHT_EXCEPTIONS = [
"tests.components.unifi.test_controller", "tests.components.unifi.test_controller",
"test_wireless_client_event_calls_update_wireless_devices", "test_wireless_client_event_calls_update_wireless_devices",
), ),
("tests.components.iaqualink.test_config_flow", "test_with_invalid_credentials"),
("tests.components.iaqualink.test_config_flow", "test_with_existing_config"),
] ]