jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 19:27:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not check ble scanner state for sleepy shelly devices (#85566)

Browse Source 
fixes #85563
This commit is contained in:
J. Nick Koston 2023-01-09 12:16:14 -10:00 committed by GitHub
parent 02897fb9a3
commit 2c95c0b3a1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
homeassistant/components/shelly/coordinator.py
View File

@ -509,6 +509,7 @@ class ShellyRpcCoordinator(DataUpdateCoordinator[None]):
This will be executed on connect or when the config entry This will be executed on connect or when the config entry
is updated. is updated.
""" """
if not self.entry.data.get(CONF_SLEEP_PERIOD):
await self._async_connect_ble_scanner() await self._async_connect_ble_scanner()
async def _async_connect_ble_scanner(self) -> None: async def _async_connect_ble_scanner(self) -> None:

16
tests/components/shelly/test_init.py
View File

@ -213,7 +213,7 @@ async def test_entry_unload_not_connected(hass, mock_rpc_device, monkeypatch):
assert entry.state is ConfigEntryState.LOADED assert entry.state is ConfigEntryState.LOADED
async def test_entry_unload_not_connected_but_we_with_we_are( async def test_entry_unload_not_connected_but_we_think_we_are(
hass, mock_rpc_device, monkeypatch hass, mock_rpc_device, monkeypatch
): ):
"""Test entry unload when not connected but we think we are still connected.""" """Test entry unload when not connected but we think we are still connected."""
@ -238,3 +238,17 @@ async def test_entry_unload_not_connected_but_we_with_we_are(
assert not mock_stop_scanner.call_count assert not mock_stop_scanner.call_count
assert entry.state is ConfigEntryState.LOADED assert entry.state is ConfigEntryState.LOADED
async def test_no_attempt_to_stop_scanner_with_sleepy_devices(hass, mock_rpc_device):
"""Test we do not try to stop the scanner if its disabled with a sleepy device."""
with patch(
"homeassistant.components.shelly.coordinator.async_stop_scanner",
) as mock_stop_scanner:
entry = await init_integration(hass, 2, sleep_period=7200)
assert entry.state is ConfigEntryState.LOADED
assert not mock_stop_scanner.call_count
mock_rpc_device.mock_update()
await hass.async_block_till_done()
assert not mock_stop_scanner.call_count