From 2d02baf3d0937d2c43957d05ab8458ad8fc4c214 Mon Sep 17 00:00:00 2001 From: DaveSergeant Date: Tue, 29 Nov 2016 08:50:12 -0800 Subject: [PATCH] Default dimmable brightness to 255 from 100 (#4621) * Default dimmable brightness to 255 from 100 Full brightness for ISY dimmers is 255. The current 100 value turns dimmer switches on to just under half brightness. Probably just an oversight from the Sept implementation. * Brightness change for turn_on, ramp for turn_off. Per discussion with Teagan42 and jbcodemonkey, the brightness should rightfully be None and not an explicit value. There is a continuing issue that the ISY modules don't respect HA's brightness customization values. A new issue will be opened for this. Additionally, turn_off was using ISY's fastoff() which didn't respect the ramping time. The default behavior should just be off(). --- homeassistant/components/light/isy994.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/homeassistant/components/light/isy994.py b/homeassistant/components/light/isy994.py index d8a6f558865..952c52b2809 100644 --- a/homeassistant/components/light/isy994.py +++ b/homeassistant/components/light/isy994.py @@ -61,10 +61,10 @@ class ISYLightDevice(isy.ISYDevice, Light): def turn_off(self, **kwargs) -> None: """Send the turn off command to the ISY994 light device.""" - if not self._node.fastoff(): + if not self._node.off(): _LOGGER.debug('Unable to turn on light.') - def turn_on(self, brightness=100, **kwargs) -> None: + def turn_on(self, brightness=None, **kwargs) -> None: """Send the turn on command to the ISY994 light device.""" if not self._node.on(val=brightness): _LOGGER.debug('Unable to turn on light.')