jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-10 23:07:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor code cleanup

Browse Source
This commit is contained in:
Heath Paddock 2015-09-15 23:45:12 -05:00
parent 90e21791f6
commit 2fd7b98cab
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
homeassistant/components/camera/foscam.py
View File

@ -61,7 +61,7 @@ _LOGGER = logging.getLogger(__name__)
# pylint: disable=unused-argument # pylint: disable=unused-argument
def setup_platform(hass, config, add_devices_callback, discovery_info=None): def setup_platform(hass, config, add_devices_callback, discovery_info=None):
""" Adds a generic IP Camera. """ """ Adds a Foscam IP Camera. """
if not validate_config({DOMAIN: config}, {DOMAIN: ['username', 'password', 'ip']}, _LOGGER): if not validate_config({DOMAIN: config}, {DOMAIN: ['username', 'password', 'ip']}, _LOGGER):
return None return None
@ -76,15 +76,17 @@ class FoscamCamera(Camera):
def __init__(self, device_info): def __init__(self, device_info):
super().__init__() super().__init__()
self._name = device_info.get('name', 'Foscam Camera')
self._username = device_info.get('username')
self._password = device_info.get('password')
ip = device_info.get('ip')
port = device_info.get('port', 88) port = device_info.get('port', 88)
self._base_url = 'http://' + device_info.get('ip') + ':' + str(port) + '/' self._base_url = 'http://' + ip + ':' + str(port) + '/'
self._username = device_info.get('username')
self._password = device_info.get('password')
self._snap_picture_url = self._base_url + 'cgi-bin/CGIProxy.fcgi?cmd=snapPicture&usr=' + self._username + '&pwd=' + self._password self._snap_picture_url = self._base_url + 'cgi-bin/CGIProxy.fcgi?cmd=snapPicture&usr=' + self._username + '&pwd=' + self._password
_LOGGER.info('Using the following URL for Foscam camera: ' + self._snap_picture_url) self._name = device_info.get('name', 'Foscam Camera')
_LOGGER.info('Using the following URL for %s: %s', self._name, self._snap_picture_url)
def camera_image(self): def camera_image(self):
""" Return a still image reponse from the camera """ """ Return a still image reponse from the camera """