jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 03:07:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

respect pylint suggestions

Browse Source
This commit is contained in:
Malte Deiseroth 2015-09-22 12:32:45 +02:00
parent 3829abbd2d
commit 3027b4a5a8
1 changed files with 18 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
homeassistant/components/sensor/onewire.py
View File

@ -19,24 +19,25 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
""" Sets up the one wire Sensors""" """ Sets up the one wire Sensors"""
if DEVICE_FILES == []: if DEVICE_FILES == []:
_LOGGER.error('No onewire sensor found. Check if dtoverlay=w1-gpio,gpiopin=4 is in your /boot/config.txt and the correct gpiopin number is set.') _LOGGER.error('No onewire sensor found. Check if
dtoverlay=w1-gpio,gpiopin=4 is in your /boot/config.txt
and the correct gpiopin number is set.')
return return
devs = [] devs = []
names = SENSOR_IDS names = SENSOR_IDS
for key in config.keys(): for key in config.keys():
if key=="names": if key == "names":
## only one name given ## only one name given
if isinstance(config['names'], str): if isinstance(config['names'], str):
names = [config['names']] names = [config['names']]
## map names and sensors in given order ## map names and sensors in given order
elif isinstance(config['names'], list): elif isinstance(config['names'], list):
names = config['names'] names = config['names']
## map names to ids. ## map names to ids.
elif isinstance(config['names'], dict): elif isinstance(config['names'], dict):
names = [config['names'].get(sensor_id, sensor_id) for sensor_id in SENSOR_IDS] names = [config['names'].get(sensor_id, sensor_id) for sensor_id in SENSOR_IDS]
for device_file, name in zip(DEVICE_FILES, names): for device_file, name in zip(DEVICE_FILES, names):
devs.append(OneWire(name, device_file, TEMP_CELCIUS)) devs.append(OneWire(name, device_file, TEMP_CELCIUS))
add_devices(devs) add_devices(devs)
@ -50,9 +51,10 @@ class OneWire(Entity):
self._unit_of_measurement = unit_of_measurement self._unit_of_measurement = unit_of_measurement
def _read_temp_raw(self): def _read_temp_raw(self):
f = open(self._device_file, 'r') """ read the temperature as it is returned by the sensor"""
lines = f.readlines() ds_device_file = open(self._device_file, 'r')
f.close() lines = ds_device_file.readlines()
ds_device_file.close()
return lines return lines
@property @property
@ -74,11 +76,10 @@ class OneWire(Entity):
if equals_pos != -1: if equals_pos != -1:
temp_string = lines[1][equals_pos+2:] temp_string = lines[1][equals_pos+2:]
temp = float(temp_string) / 1000.0 temp = float(temp_string) / 1000.0
if self._unit_of_measurement == TEMP_FAHRENHEIT: if self._unit_of_measurement == TEMP_FAHRENHEIT:
temp = temp * 9.0 / 5.0 + 32.0 temp = temp * 9.0 / 5.0 + 32.0
return temp return temp
@property @property
def unit_of_measurement(self): def unit_of_measurement(self):
return self._unit_of_measurement return self._unit_of_measurement