jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-26 14:47:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix attribute error for media_player/roku if roku device is unreachable and shows a persistent notification (#5785) (#5786)

Browse Source
This commit is contained in:
Marcelo Moreira de Mello 2017-02-07 01:00:20 -05:00 committed by Paulus Schoutsen
parent 34c7bac9b4
commit 305d2612cf
1 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
homeassistant/components/media_player/roku.py
View File

@ -15,6 +15,7 @@ from homeassistant.components.media_player import (
from homeassistant.const import ( from homeassistant.const import (
CONF_HOST, STATE_IDLE, STATE_PLAYING, STATE_UNKNOWN, STATE_HOME) CONF_HOST, STATE_IDLE, STATE_PLAYING, STATE_UNKNOWN, STATE_HOME)
import homeassistant.helpers.config_validation as cv import homeassistant.helpers.config_validation as cv
import homeassistant.loader as loader
REQUIREMENTS = [ REQUIREMENTS = [
'https://github.com/bah2830/python-roku/archive/3.1.3.zip' 'https://github.com/bah2830/python-roku/archive/3.1.3.zip'
@ -23,6 +24,9 @@ REQUIREMENTS = [
KNOWN_HOSTS = [] KNOWN_HOSTS = []
DEFAULT_PORT = 8060 DEFAULT_PORT = 8060
NOTIFICATION_ID = 'roku_notification'
NOTIFICATION_TITLE = 'Roku Media Player Setup'
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
SUPPORT_ROKU = SUPPORT_PREVIOUS_TRACK | SUPPORT_NEXT_TRACK |\ SUPPORT_ROKU = SUPPORT_PREVIOUS_TRACK | SUPPORT_NEXT_TRACK |\
@ -48,15 +52,28 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
elif CONF_HOST in config: elif CONF_HOST in config:
hosts.append(config.get(CONF_HOST)) hosts.append(config.get(CONF_HOST))
persistent_notification = loader.get_component('persistent_notification')
rokus = [] rokus = []
for host in hosts: for host in hosts:
new_roku = RokuDevice(host) new_roku = RokuDevice(host)
if new_roku.name is None: try:
if new_roku.name is not None:
rokus.append(RokuDevice(host))
KNOWN_HOSTS.append(host)
else:
_LOGGER.error("Unable to initialize roku at %s", host)
except AttributeError:
_LOGGER.error("Unable to initialize roku at %s", host) _LOGGER.error("Unable to initialize roku at %s", host)
else: persistent_notification.create(
rokus.append(RokuDevice(host)) hass, 'Error: Unable to initialize roku at {}<br />'
KNOWN_HOSTS.append(host) 'Check its network connection or consider '
'using auto discovery.<br />'
'You will need to restart hass after fixing.'
''.format(config.get(CONF_HOST)),
title=NOTIFICATION_TITLE,
notification_id=NOTIFICATION_ID)
add_devices(rokus) add_devices(rokus)