jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 13:17:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address late review comments on Netatmo (#53524)

Browse Source
This commit is contained in:
Tobias Sauerwein 2021-07-27 00:42:36 +02:00 committed by GitHub
parent 0b44265232
commit 31079a05b3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
homeassistant/components/netatmo/camera.py
View File

@ -36,7 +36,6 @@ from .const import (
SERVICE_SET_PERSON_AWAY, SERVICE_SET_PERSON_AWAY,
SERVICE_SET_PERSONS_HOME, SERVICE_SET_PERSONS_HOME,
SIGNAL_NAME, SIGNAL_NAME,
UNKNOWN,
WEBHOOK_LIGHT_MODE, WEBHOOK_LIGHT_MODE,
WEBHOOK_NACAMERA_CONNECTION, WEBHOOK_NACAMERA_CONNECTION,
WEBHOOK_PUSH_TYPE, WEBHOOK_PUSH_TYPE,
@ -132,9 +131,7 @@ class NetatmoCamera(NetatmoBase, Camera):
self._id = camera_id self._id = camera_id
self._home_id = home_id self._home_id = home_id
self._device_name = self._data.get_camera(camera_id=camera_id).get( self._device_name = self._data.get_camera(camera_id=camera_id)["name"]
"name", UNKNOWN
)
self._attr_name = f"{MANUFACTURER} {self._device_name}" self._attr_name = f"{MANUFACTURER} {self._device_name}"
self._model = camera_type self._model = camera_type
self._attr_unique_id = f"{self._id}-{self._model}" self._attr_unique_id = f"{self._id}-{self._model}"

3
homeassistant/components/netatmo/const.py
View File

@ -6,7 +6,6 @@ from homeassistant.components.select import DOMAIN as SELECT_DOMAIN
from homeassistant.components.sensor import DOMAIN as SENSOR_DOMAIN from homeassistant.components.sensor import DOMAIN as SENSOR_DOMAIN
API = "api" API = "api"
UNKNOWN = "unknown"
DOMAIN = "netatmo" DOMAIN = "netatmo"
MANUFACTURER = "Netatmo" MANUFACTURER = "Netatmo"
@ -77,7 +76,7 @@ DATA_SCHEDULES = "netatmo_schedules"
NETATMO_WEBHOOK_URL = None NETATMO_WEBHOOK_URL = None
NETATMO_EVENT = "netatmo_event" NETATMO_EVENT = "netatmo_event"
DEFAULT_PERSON = UNKNOWN DEFAULT_PERSON = "unknown"
DEFAULT_DISCOVERY = True DEFAULT_DISCOVERY = True
DEFAULT_WEBHOOKS = False DEFAULT_WEBHOOKS = False

5
homeassistant/components/netatmo/device_trigger.py
View File

@ -144,10 +144,7 @@ async def async_attach_trigger(
ATTR_DEVICE_ID: config[ATTR_DEVICE_ID], ATTR_DEVICE_ID: config[ATTR_DEVICE_ID],
}, },
} }
# if config[CONF_TYPE] in SUBTYPES:
# event_config[event_trigger.CONF_EVENT_DATA]["data"] = {
# "mode": config[CONF_SUBTYPE]
# }
if config[CONF_TYPE] in SUBTYPES: if config[CONF_TYPE] in SUBTYPES:
event_config.update( event_config.update(
{event_trigger.CONF_EVENT_DATA: {"data": {"mode": config[CONF_SUBTYPE]}}} {event_trigger.CONF_EVENT_DATA: {"data": {"mode": config[CONF_SUBTYPE]}}}

3
homeassistant/components/netatmo/light.py
View File

@ -19,7 +19,6 @@ from .const import (
EVENT_TYPE_LIGHT_MODE, EVENT_TYPE_LIGHT_MODE,
MANUFACTURER, MANUFACTURER,
SIGNAL_NAME, SIGNAL_NAME,
UNKNOWN,
WEBHOOK_LIGHT_MODE, WEBHOOK_LIGHT_MODE,
WEBHOOK_PUSH_TYPE, WEBHOOK_PUSH_TYPE,
) )
@ -89,7 +88,7 @@ class NetatmoLight(NetatmoBase, LightEntity):
self._id = camera_id self._id = camera_id
self._home_id = home_id self._home_id = home_id
self._model = camera_type self._model = camera_type
self._device_name: str = self._data.get_camera(camera_id).get("name", UNKNOWN) self._device_name: str = self._data.get_camera(camera_id)["name"]
self._attr_name = f"{MANUFACTURER} {self._device_name}" self._attr_name = f"{MANUFACTURER} {self._device_name}"
self._is_on = False self._is_on = False
self._attr_unique_id = f"{self._id}-light" self._attr_unique_id = f"{self._id}-light"