mirror of
https://github.com/home-assistant/core.git
synced 2025-07-16 17:57:11 +00:00
Remove deprecated supported features warning in Siren (#132666)
This commit is contained in:
parent
427db02029
commit
31150bf897
@ -191,9 +191,4 @@ class SirenEntity(ToggleEntity, cached_properties=CACHED_PROPERTIES_WITH_ATTR_):
|
|||||||
@cached_property
|
@cached_property
|
||||||
def supported_features(self) -> SirenEntityFeature:
|
def supported_features(self) -> SirenEntityFeature:
|
||||||
"""Return the list of supported features."""
|
"""Return the list of supported features."""
|
||||||
features = self._attr_supported_features
|
return self._attr_supported_features
|
||||||
if type(features) is int: # noqa: E721
|
|
||||||
new_features = SirenEntityFeature(features)
|
|
||||||
self._report_deprecated_supported_features_values(new_features)
|
|
||||||
return new_features
|
|
||||||
return features
|
|
||||||
|
@ -4,7 +4,6 @@ from unittest.mock import MagicMock
|
|||||||
|
|
||||||
import pytest
|
import pytest
|
||||||
|
|
||||||
from homeassistant.components import siren
|
|
||||||
from homeassistant.components.siren import (
|
from homeassistant.components.siren import (
|
||||||
SirenEntity,
|
SirenEntity,
|
||||||
SirenEntityDescription,
|
SirenEntityDescription,
|
||||||
@ -106,20 +105,3 @@ async def test_missing_tones_dict(hass: HomeAssistant) -> None:
|
|||||||
siren.hass = hass
|
siren.hass = hass
|
||||||
with pytest.raises(ValueError):
|
with pytest.raises(ValueError):
|
||||||
process_turn_on_params(siren, {"tone": 3})
|
process_turn_on_params(siren, {"tone": 3})
|
||||||
|
|
||||||
|
|
||||||
def test_deprecated_supported_features_ints(caplog: pytest.LogCaptureFixture) -> None:
|
|
||||||
"""Test deprecated supported features ints."""
|
|
||||||
|
|
||||||
class MockSirenEntity(siren.SirenEntity):
|
|
||||||
_attr_supported_features = 1
|
|
||||||
|
|
||||||
entity = MockSirenEntity()
|
|
||||||
assert entity.supported_features is siren.SirenEntityFeature(1)
|
|
||||||
assert "MockSirenEntity" in caplog.text
|
|
||||||
assert "is using deprecated supported features values" in caplog.text
|
|
||||||
assert "Instead it should use" in caplog.text
|
|
||||||
assert "SirenEntityFeature.TURN_ON" in caplog.text
|
|
||||||
caplog.clear()
|
|
||||||
assert entity.supported_features is siren.SirenEntityFeature(1)
|
|
||||||
assert "is using deprecated supported features values" not in caplog.text
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user