jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-25 14:17:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Change http to auto for cast media image url" (#44327)

Browse Source
This commit is contained in:
Erik Montnemery 2020-12-17 17:43:52 +01:00 committed by GitHub
parent 2b6842aee0
commit 31b806ced1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/components/cast/media_player.py
View File

@ -665,9 +665,7 @@ class CastDevice(MediaPlayerEntity):
images = media_status.images images = media_status.images
return ( return images[0].url if images and images[0].url else None
images[0].url.replace("http://", "//") if images and images[0].url else None
)
@property @property
def media_image_remotely_accessible(self) -> bool: def media_image_remotely_accessible(self) -> bool:

44
tests/components/cast/test_media_player.py
View File

@ -787,50 +787,6 @@ async def test_entity_media_states(hass: HomeAssistantType):
assert state.state == "unknown" assert state.state == "unknown"
async def test_url_replace(hass: HomeAssistantType):
"""Test functionality of replacing URL for HTTPS."""
entity_id = "media_player.speaker"
reg = await hass.helpers.entity_registry.async_get_registry()
info = get_fake_chromecast_info()
full_info = attr.evolve(
info, model_name="google home", friendly_name="Speaker", uuid=FakeUUID
)
chromecast = await async_setup_media_player_cast(hass, info)
_, conn_status_cb, media_status_cb = get_status_callbacks(chromecast)
connection_status = MagicMock()
connection_status.status = "CONNECTED"
conn_status_cb(connection_status)
await hass.async_block_till_done()
state = hass.states.get(entity_id)
assert state is not None
assert state.name == "Speaker"
assert state.state == "unknown"
assert entity_id == reg.async_get_entity_id("media_player", "cast", full_info.uuid)
class FakeHTTPImage:
url = "http://example.com/test.png"
class FakeHTTPSImage:
url = "https://example.com/test.png"
media_status = MagicMock(images=[FakeHTTPImage()])
media_status.player_is_playing = True
media_status_cb(media_status)
await hass.async_block_till_done()
state = hass.states.get(entity_id)
assert state.attributes.get("entity_picture") == "//example.com/test.png"
media_status.images = [FakeHTTPSImage()]
media_status_cb(media_status)
await hass.async_block_till_done()
state = hass.states.get(entity_id)
assert state.attributes.get("entity_picture") == "https://example.com/test.png"
async def test_group_media_states(hass, mz_mock): async def test_group_media_states(hass, mz_mock):
"""Test media states are read from group if entity has no state.""" """Test media states are read from group if entity has no state."""
entity_id = "media_player.speaker" entity_id = "media_player.speaker"