jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 13:17:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix AsusWRT wrong api call (#47522)

Browse Source
This commit is contained in:
ollo69 2021-03-08 19:34:12 +01:00 committed by GitHub
parent f9e33a4a0d
commit 32476a3fed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CODEOWNERS
View File

@ -46,7 +46,7 @@ homeassistant/components/arcam_fmj/* @elupus
homeassistant/components/arduino/* @fabaff homeassistant/components/arduino/* @fabaff
homeassistant/components/arest/* @fabaff homeassistant/components/arest/* @fabaff
homeassistant/components/arris_tg2492lg/* @vanbalken homeassistant/components/arris_tg2492lg/* @vanbalken
homeassistant/components/asuswrt/* @kennedyshead homeassistant/components/asuswrt/* @kennedyshead @ollo69
homeassistant/components/atag/* @MatsNL homeassistant/components/atag/* @MatsNL
homeassistant/components/aten_pe/* @mtdcr homeassistant/components/aten_pe/* @mtdcr
homeassistant/components/atome/* @baqs homeassistant/components/atome/* @baqs

2
homeassistant/components/asuswrt/config_flow.py
View File

@ -127,7 +127,7 @@ class AsusWrtFlowHandler(config_entries.ConfigFlow, domain=DOMAIN):
conf_protocol = user_input[CONF_PROTOCOL] conf_protocol = user_input[CONF_PROTOCOL]
if conf_protocol == PROTOCOL_TELNET: if conf_protocol == PROTOCOL_TELNET:
await api.connection.disconnect() api.connection.disconnect()
return RESULT_SUCCESS return RESULT_SUCCESS
async def async_step_user(self, user_input=None): async def async_step_user(self, user_input=None):

2
homeassistant/components/asuswrt/manifest.json
View File

@ -4,5 +4,5 @@
"config_flow": true, "config_flow": true,
"documentation": "https://www.home-assistant.io/integrations/asuswrt", "documentation": "https://www.home-assistant.io/integrations/asuswrt",
"requirements": ["aioasuswrt==1.3.1"], "requirements": ["aioasuswrt==1.3.1"],
"codeowners": ["@kennedyshead"] "codeowners": ["@kennedyshead", "@ollo69"]
} }

2
homeassistant/components/asuswrt/router.py
View File

@ -341,7 +341,7 @@ class AsusWrtRouter:
"""Close the connection.""" """Close the connection."""
if self._api is not None: if self._api is not None:
if self._protocol == PROTOCOL_TELNET: if self._protocol == PROTOCOL_TELNET:
await self._api.connection.disconnect() self._api.connection.disconnect()
self._api = None self._api = None
for func in self._on_close: for func in self._on_close:

4
tests/components/asuswrt/test_config_flow.py
View File

@ -1,6 +1,6 @@
"""Tests for the AsusWrt config flow.""" """Tests for the AsusWrt config flow."""
from socket import gaierror from socket import gaierror
from unittest.mock import AsyncMock, patch from unittest.mock import AsyncMock, Mock, patch
import pytest import pytest
@ -46,7 +46,7 @@ def mock_controller_connect():
with patch("homeassistant.components.asuswrt.router.AsusWrt") as service_mock: with patch("homeassistant.components.asuswrt.router.AsusWrt") as service_mock:
service_mock.return_value.connection.async_connect = AsyncMock() service_mock.return_value.connection.async_connect = AsyncMock()
service_mock.return_value.is_connected = True service_mock.return_value.is_connected = True
service_mock.return_value.connection.disconnect = AsyncMock() service_mock.return_value.connection.disconnect = Mock()
yield service_mock yield service_mock

4
tests/components/asuswrt/test_sensor.py
View File

@ -1,6 +1,6 @@
"""Tests for the AsusWrt sensor.""" """Tests for the AsusWrt sensor."""
from datetime import timedelta from datetime import timedelta
from unittest.mock import AsyncMock, patch from unittest.mock import AsyncMock, Mock, patch
from aioasuswrt.asuswrt import Device from aioasuswrt.asuswrt import Device
import pytest import pytest
@ -49,7 +49,7 @@ def mock_controller_connect():
with patch("homeassistant.components.asuswrt.router.AsusWrt") as service_mock: with patch("homeassistant.components.asuswrt.router.AsusWrt") as service_mock:
service_mock.return_value.connection.async_connect = AsyncMock() service_mock.return_value.connection.async_connect = AsyncMock()
service_mock.return_value.is_connected = True service_mock.return_value.is_connected = True
service_mock.return_value.connection.disconnect = AsyncMock() service_mock.return_value.connection.disconnect = Mock()
service_mock.return_value.async_get_connected_devices = AsyncMock( service_mock.return_value.async_get_connected_devices = AsyncMock(
return_value=MOCK_DEVICES return_value=MOCK_DEVICES
) )