jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 05:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Heat control config validation

Browse Source 
* heat control configuration validation

* fix heat contol test
This commit is contained in:
Daniel Høyer Iversen 2016-04-21 16:59:35 +02:00 committed by Paulus Schoutsen
parent d3fb69783d
commit 3318c55c65
2 changed files with 28 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
homeassistant/components/thermostat/heat_control.py
View File

@ -5,7 +5,9 @@ For more details about this platform, please refer to the documentation at
https://home-assistant.io/components/thermostat.heat_control/ https://home-assistant.io/components/thermostat.heat_control/
""" """
import logging import logging
import voluptuous as vol
import homeassistant.helpers.config_validation as cv
import homeassistant.util as util import homeassistant.util as util
from homeassistant.components import switch from homeassistant.components import switch
from homeassistant.components.thermostat import ( from homeassistant.components.thermostat import (
@ -28,21 +30,26 @@ CONF_TARGET_TEMP = 'target_temp'
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
PLATFORM_SCHEMA = vol.Schema({
vol.Required("platform"): "heat_control",
vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string,
vol.Required(CONF_HEATER): cv.entity_id,
vol.Required(CONF_SENSOR): cv.entity_id,
vol.Optional(CONF_MIN_TEMP): vol.Coerce(float),
vol.Optional(CONF_MAX_TEMP): vol.Coerce(float),
vol.Optional(CONF_TARGET_TEMP): vol.Coerce(float),
})
# pylint: disable=unused-argument # pylint: disable=unused-argument
def setup_platform(hass, config, add_devices, discovery_info=None): def setup_platform(hass, config, add_devices, discovery_info=None):
"""Setup the heat control thermostat.""" """Setup the heat control thermostat."""
name = config.get(CONF_NAME, DEFAULT_NAME) name = config.get(CONF_NAME)
heater_entity_id = config.get(CONF_HEATER) heater_entity_id = config.get(CONF_HEATER)
sensor_entity_id = config.get(CONF_SENSOR) sensor_entity_id = config.get(CONF_SENSOR)
min_temp = util.convert(config.get(CONF_MIN_TEMP), float, None) min_temp = config.get(CONF_MIN_TEMP)
max_temp = util.convert(config.get(CONF_MAX_TEMP), float, None) max_temp = config.get(CONF_MAX_TEMP)
target_temp = util.convert(config.get(CONF_TARGET_TEMP), float, None) target_temp = config.get(CONF_TARGET_TEMP)
if None in (heater_entity_id, sensor_entity_id):
_LOGGER.error('Missing required key %s or %s', CONF_HEATER,
CONF_SENSOR)
return False
add_devices([HeatControl(hass, name, heater_entity_id, sensor_entity_id, add_devices([HeatControl(hass, name, heater_entity_id, sensor_entity_id,
min_temp, max_temp, target_temp)]) min_temp, max_temp, target_temp)])

17
tests/components/thermostat/test_heat_control.py
View File

@ -1,7 +1,7 @@
"""The tests for the heat control thermostat.""" """The tests for the heat control thermostat."""
import unittest import unittest
from unittest import mock
from homeassistant.bootstrap import _setup_component
from homeassistant.const import ( from homeassistant.const import (
ATTR_UNIT_OF_MEASUREMENT, ATTR_UNIT_OF_MEASUREMENT,
SERVICE_TURN_OFF, SERVICE_TURN_OFF,
@ -11,7 +11,6 @@ from homeassistant.const import (
TEMP_CELSIUS, TEMP_CELSIUS,
) )
from homeassistant.components import thermostat from homeassistant.components import thermostat
import homeassistant.components.thermostat.heat_control as heat_control
from tests.common import get_test_home_assistant from tests.common import get_test_home_assistant
@ -41,9 +40,17 @@ class TestSetupThermostatHeatControl(unittest.TestCase):
'name': 'test', 'name': 'test',
'target_sensor': ENT_SENSOR 'target_sensor': ENT_SENSOR
} }
add_devices = mock.MagicMock() self.assertFalse(_setup_component(self.hass, 'thermostat', {
result = heat_control.setup_platform(self.hass, config, add_devices) 'thermostat': config}))
self.assertEqual(False, result)
def test_valid_conf(self):
"""Test set up heat_control with valid config values."""
self.assertTrue(_setup_component(self.hass, 'thermostat',
{'thermostat': {
'platform': 'heat_control',
'name': 'test',
'heater': ENT_SWITCH,
'target_sensor': ENT_SENSOR}}))
def test_setup_with_sensor(self): def test_setup_with_sensor(self):
"""Test set up heat_control with sensor to trigger update at init.""" """Test set up heat_control with sensor to trigger update at init."""