From 342e55409a65624253304091a0525b91b6cb66c3 Mon Sep 17 00:00:00 2001 From: Joost Lekkerkerker Date: Tue, 22 Aug 2023 19:55:47 +0200 Subject: [PATCH] Add entity translations to OpenGarage (#98834) --- homeassistant/components/opengarage/binary_sensor.py | 4 +--- homeassistant/components/opengarage/cover.py | 2 +- homeassistant/components/opengarage/entity.py | 2 ++ homeassistant/components/opengarage/sensor.py | 3 --- homeassistant/components/opengarage/strings.json | 7 +++++++ 5 files changed, 11 insertions(+), 7 deletions(-) diff --git a/homeassistant/components/opengarage/binary_sensor.py b/homeassistant/components/opengarage/binary_sensor.py index 64bc7c83d20..22f118ca804 100644 --- a/homeassistant/components/opengarage/binary_sensor.py +++ b/homeassistant/components/opengarage/binary_sensor.py @@ -22,6 +22,7 @@ _LOGGER = logging.getLogger(__name__) SENSOR_TYPES: tuple[BinarySensorEntityDescription, ...] = ( BinarySensorEntityDescription( key="vehicle", + translation_key="vehicle", ), ) @@ -66,9 +67,6 @@ class OpenGarageBinarySensor(OpenGarageEntity, BinarySensorEntity): @callback def _update_attr(self) -> None: """Handle updated data from the coordinator.""" - self._attr_name = ( - f'{self.coordinator.data["name"]} {self.entity_description.key}' - ) state = self.coordinator.data.get(self.entity_description.key) if state == 1: self._attr_is_on = True diff --git a/homeassistant/components/opengarage/cover.py b/homeassistant/components/opengarage/cover.py index 15669a41736..3f3f6b11acf 100644 --- a/homeassistant/components/opengarage/cover.py +++ b/homeassistant/components/opengarage/cover.py @@ -37,6 +37,7 @@ class OpenGarageCover(OpenGarageEntity, CoverEntity): _attr_device_class = CoverDeviceClass.GARAGE _attr_supported_features = CoverEntityFeature.OPEN | CoverEntityFeature.CLOSE + _attr_name = None def __init__( self, coordinator: OpenGarageDataUpdateCoordinator, device_id: str @@ -89,7 +90,6 @@ class OpenGarageCover(OpenGarageEntity, CoverEntity): """Update the state and attributes.""" status = self.coordinator.data - self._attr_name = status["name"] state = STATES_MAP.get(status.get("door")) # type: ignore[arg-type] if self._state_before_move is not None: if self._state_before_move != state: diff --git a/homeassistant/components/opengarage/entity.py b/homeassistant/components/opengarage/entity.py index 678f43afb6e..c8380ea9244 100644 --- a/homeassistant/components/opengarage/entity.py +++ b/homeassistant/components/opengarage/entity.py @@ -12,6 +12,8 @@ from . import DOMAIN, OpenGarageDataUpdateCoordinator class OpenGarageEntity(CoordinatorEntity[OpenGarageDataUpdateCoordinator]): """Representation of a OpenGarage entity.""" + _attr_has_entity_name = True + def __init__( self, open_garage_data_coordinator: OpenGarageDataUpdateCoordinator, diff --git a/homeassistant/components/opengarage/sensor.py b/homeassistant/components/opengarage/sensor.py index 796192b406f..b1d6cb921fa 100644 --- a/homeassistant/components/opengarage/sensor.py +++ b/homeassistant/components/opengarage/sensor.py @@ -83,7 +83,4 @@ class OpenGarageSensor(OpenGarageEntity, SensorEntity): @callback def _update_attr(self) -> None: """Handle updated data from the coordinator.""" - self._attr_name = ( - f'{self.coordinator.data["name"]} {self.entity_description.key}' - ) self._attr_native_value = self.coordinator.data.get(self.entity_description.key) diff --git a/homeassistant/components/opengarage/strings.json b/homeassistant/components/opengarage/strings.json index 26f2f94ff9f..ba4521d4dcf 100644 --- a/homeassistant/components/opengarage/strings.json +++ b/homeassistant/components/opengarage/strings.json @@ -18,5 +18,12 @@ "abort": { "already_configured": "[%key:common::config_flow::abort::already_configured_device%]" } + }, + "entity": { + "binary_sensor": { + "vehicle": { + "name": "Vehicle" + } + } } }