From 34cbf26e2fed42102eb9dbc7d720da947dd24de3 Mon Sep 17 00:00:00 2001 From: rappenze Date: Sat, 7 May 2022 22:20:30 +0200 Subject: [PATCH] Revert usage of Fibaro Client V5 as it has too many errors (#71477) --- homeassistant/components/fibaro/__init__.py | 23 +++++++-------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/homeassistant/components/fibaro/__init__.py b/homeassistant/components/fibaro/__init__.py index d5a8f94970d..c9b0cb345e1 100644 --- a/homeassistant/components/fibaro/__init__.py +++ b/homeassistant/components/fibaro/__init__.py @@ -10,10 +10,7 @@ from fiblary3.client.v4.client import ( Client as FibaroClientV4, StateHandler as StateHandlerV4, ) -from fiblary3.client.v5.client import ( - Client as FibaroClientV5, - StateHandler as StateHandlerV5, -) +from fiblary3.client.v5.client import StateHandler as StateHandlerV5 from fiblary3.common.exceptions import HTTPException import voluptuous as vol @@ -141,18 +138,12 @@ class FibaroController: should do that only when you use the FibaroController for login test as only the login and info API's are equal throughout the different versions. """ - if ( - serial_number is None - or serial_number.upper().startswith("HC2") - or serial_number.upper().startswith("HCL") - ): - self._client = FibaroClientV4( - config[CONF_URL], config[CONF_USERNAME], config[CONF_PASSWORD] - ) - else: - self._client = FibaroClientV5( - config[CONF_URL], config[CONF_USERNAME], config[CONF_PASSWORD] - ) + + # Only use V4 API as it works better even for HC3, after the library is fixed, we should + # add here support for the newer library version V5 again. + self._client = FibaroClientV4( + config[CONF_URL], config[CONF_USERNAME], config[CONF_PASSWORD] + ) self._scene_map = None # Whether to import devices from plugins