jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 11:17:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle EVENT_STATE_CHANGED with no new_state in graphite

Browse Source 
I noticed some events that came in with new_state=None. Make graphite
defensive about this.
This commit is contained in:
Dan Smith 2016-02-14 15:57:03 -08:00
parent 366595fd90
commit 3610f40a6a
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
homeassistant/components/graphite.py
View File

@ -110,7 +110,7 @@ class GraphiteFeeder(threading.Thread):
self._queue.task_done() self._queue.task_done()
return return
elif (event.event_type == EVENT_STATE_CHANGED and elif (event.event_type == EVENT_STATE_CHANGED and
'new_state' in event.data): event.data.get('new_state')):
self._report_attributes(event.data['entity_id'], self._report_attributes(event.data['entity_id'],
event.data['new_state']) event.data['new_state'])
self._queue.task_done() self._queue.task_done()

3
tests/components/test_graphite.py
View File

@ -171,7 +171,8 @@ class TestGraphite(unittest.TestCase):
return self.gf._quit_object return self.gf._quit_object
elif runs: elif runs:
runs.append(1) runs.append(1)
return mock.MagicMock(event_type='somethingelse') return mock.MagicMock(event_type='somethingelse',
data={'new_event': None})
else: else:
runs.append(1) runs.append(1)
return event return event