From 3844ade572410fedaaa54fe127f5286ad5da39cc Mon Sep 17 00:00:00 2001
From: epenet <6771947+epenet@users.noreply.github.com>
Date: Mon, 18 Mar 2024 10:12:46 +0100
Subject: [PATCH] Fix unknown values in onewire (#113731)

* Fix unknown values in onewire

* Update tests
---
 homeassistant/components/onewire/binary_sensor.py         | 4 +++-
 homeassistant/components/onewire/switch.py                | 6 ++++--
 tests/components/onewire/const.py                         | 8 ++++++--
 .../components/onewire/snapshots/test_binary_sensor.ambr  | 4 ++--
 tests/components/onewire/snapshots/test_switch.ambr       | 4 ++--
 5 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/homeassistant/components/onewire/binary_sensor.py b/homeassistant/components/onewire/binary_sensor.py
index 0f98be0d892..fea78fd3760 100644
--- a/homeassistant/components/onewire/binary_sensor.py
+++ b/homeassistant/components/onewire/binary_sensor.py
@@ -144,6 +144,8 @@ class OneWireBinarySensor(OneWireEntity, BinarySensorEntity):
     entity_description: OneWireBinarySensorEntityDescription
 
     @property
-    def is_on(self) -> bool:
+    def is_on(self) -> bool | None:
         """Return true if sensor is on."""
+        if self._state is None:
+            return None
         return bool(self._state)
diff --git a/homeassistant/components/onewire/switch.py b/homeassistant/components/onewire/switch.py
index 95a712c95bc..cdf1315394e 100644
--- a/homeassistant/components/onewire/switch.py
+++ b/homeassistant/components/onewire/switch.py
@@ -208,8 +208,10 @@ class OneWireSwitch(OneWireEntity, SwitchEntity):
     entity_description: OneWireSwitchEntityDescription
 
     @property
-    def is_on(self) -> bool:
-        """Return true if sensor is on."""
+    def is_on(self) -> bool | None:
+        """Return true if switch is on."""
+        if self._state is None:
+            return None
         return bool(self._state)
 
     def turn_on(self, **kwargs: Any) -> None:
diff --git a/tests/components/onewire/const.py b/tests/components/onewire/const.py
index 7fdb6500c37..e5f8ac575e9 100644
--- a/tests/components/onewire/const.py
+++ b/tests/components/onewire/const.py
@@ -156,7 +156,9 @@ MOCK_OWPROXY_DEVICES = {
             {ATTR_INJECT_READS: b"    1"},
             {ATTR_INJECT_READS: b"    0"},
             {ATTR_INJECT_READS: b"    0"},
-            {ATTR_INJECT_READS: b"    0"},
+            {
+                ATTR_INJECT_READS: ProtocolError,
+            },
             {ATTR_INJECT_READS: b"    0"},
             {ATTR_INJECT_READS: b"    0"},
             {ATTR_INJECT_READS: b"    0"},
@@ -166,7 +168,9 @@ MOCK_OWPROXY_DEVICES = {
             {ATTR_INJECT_READS: b"    1"},
             {ATTR_INJECT_READS: b"    0"},
             {ATTR_INJECT_READS: b"    1"},
-            {ATTR_INJECT_READS: b"    0"},
+            {
+                ATTR_INJECT_READS: ProtocolError,
+            },
             {ATTR_INJECT_READS: b"    1"},
             {ATTR_INJECT_READS: b"    0"},
             {ATTR_INJECT_READS: b"    1"},
diff --git a/tests/components/onewire/snapshots/test_binary_sensor.ambr b/tests/components/onewire/snapshots/test_binary_sensor.ambr
index 60744f59c68..afdec245ea0 100644
--- a/tests/components/onewire/snapshots/test_binary_sensor.ambr
+++ b/tests/components/onewire/snapshots/test_binary_sensor.ambr
@@ -851,13 +851,13 @@
       'attributes': ReadOnlyDict({
         'device_file': '/29.111111111111/sensed.3',
         'friendly_name': '29.111111111111 Sensed 3',
-        'raw_value': 0.0,
+        'raw_value': None,
       }),
       'context': <ANY>,
       'entity_id': 'binary_sensor.29_111111111111_sensed_3',
       'last_changed': <ANY>,
       'last_updated': <ANY>,
-      'state': 'off',
+      'state': 'unknown',
     }),
     StateSnapshot({
       'attributes': ReadOnlyDict({
diff --git a/tests/components/onewire/snapshots/test_switch.ambr b/tests/components/onewire/snapshots/test_switch.ambr
index fe553ac1bfb..cd3e9708d95 100644
--- a/tests/components/onewire/snapshots/test_switch.ambr
+++ b/tests/components/onewire/snapshots/test_switch.ambr
@@ -1271,13 +1271,13 @@
       'attributes': ReadOnlyDict({
         'device_file': '/29.111111111111/PIO.3',
         'friendly_name': '29.111111111111 Programmed input-output 3',
-        'raw_value': 0.0,
+        'raw_value': None,
       }),
       'context': <ANY>,
       'entity_id': 'switch.29_111111111111_programmed_input_output_3',
       'last_changed': <ANY>,
       'last_updated': <ANY>,
-      'state': 'off',
+      'state': 'unknown',
     }),
     StateSnapshot({
       'attributes': ReadOnlyDict({